[P3A] Brave.Rewards.TipsState.2 value 4 isn't captured when a recurring tip is set

[srirambv]

Description

[P3A] Brave.Rewards.TipsState.2 value 4 isn't captured when a recurring tip is set

Steps to Reproduce

1. Clean install 1.3.116
2. Check Brave.Rewards.TipsState.2 value is set to 0
3. Enable rewards and claim grant
4. Check Brave.Rewards.TipsSate.2 value is set to 2
5. Set recurring tip to verified pub
6. Check Brave.Rewards.TipsState.2 value is set to 2 and not to 4

Actual result:

Expected result:

Should update the value without delay

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision	f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS	Linux

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @iefremov

[stephendonner]

Verified PASSED using

Brave	1.25.22 Chromium: 90.0.4430.72 (Official Build) nightly (x86_64)
Revision	b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS	macOS Version 11.2.3 (Build 20D91)

Steps:

1. new profile
2. enabled Rewards, claimed UGP grant
3. checked and verified Brave.Rewards.TipsState.2 value is set to 2
4. set recurring tip to verified pub (used https://www.youtube.com/user/JJDSampson/videos)
5. after recurring monthly tip was process, checked Brave.Rewards.TipsState.2 value confirmed it was set to 4

example	example	example

Note: the original steps to reproduce say "Check Brave.Rewards.TipsState.2 value is set to 0" before enabling Rewards, but this is no longer the case, as I think we purposefully don't set anything until we actually enable Rewards, as part of our "don't ping unless the user initiates it" edict :-)

---

Verification passed on

Brave | 1.25.53 Chromium: 90.0.4430.93 (Official Build) beta (64-bit)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | Windows 10 OS Version 2004 (Build 19041.928)

• Ensured Brave.Rewards.TipsState.2 value is set to 2 after rewards enable and UGP grants claim
  
• Ensured Brave.Rewards.TipsState.2 value is set to 4 after sending a recurring tip to a verified publisher
  [Note: required browser restart the see the value 4 which is expected]
  

---

Verification passed on

Brave	1.25.59 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
Revision	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	Ubuntu 18.04 LTS

• Ensured Brave.Rewards.TipsState.2 value is set to 2 after rewards enable and UGP grants claim
  
• Ensured Brave.Rewards.TipsState.2 value is set to 4 after sending a recurring tip to a verified publisher