Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TipConnectedPublisherAnonAndConnected browser test intermittently times out #8881

Closed
bsclifton opened this issue Mar 26, 2020 · 3 comments
Closed

Comments

@bsclifton
Copy link
Member

Description

Currently, master has intermittent failures for BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected. All other browser tests seem to work fine- but as a reviewer we need to either make a call:

  1. Replay and hope that tests run fine 2nd time
  2. Ignore that test

Steps to Reproduce

  1. Have a pull request against master
  2. Check PR builder

Actual result:

Sometimes you'll see an error like:

11:28:39  [508/508] BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected (TIMED OUT)
11:28:39  1 test timed out:
11:28:39      BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2762)

Expected result:

  • Test should either pass or (if there is a problem) fail.
  • If test is unreliable, it should be disabled

Reproduces how often:

Intermittent

cc: @NejcZdovc @tmancey

@rebron
Copy link
Collaborator

rebron commented Mar 27, 2020

At @emerick @NejcZdovc can you guys take a look? Causing a lot of CI failures.

@NejcZdovc
Copy link
Contributor

moving to global project

@NejcZdovc
Copy link
Contributor

should be fixed with brave/brave-core#4114

@NejcZdovc NejcZdovc self-assigned this Apr 1, 2020
@NejcZdovc NejcZdovc added this to the 1.8.x - Nightly milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants