Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewards panel shows wrong site info when tweeting about a tip sometimes #9136

Closed
LaurenWags opened this issue Apr 10, 2020 · 4 comments
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Apr 10, 2020

Description

While retesting #5544, I found that I get the wrong publisher info on the rewards panel in certain cases.

Steps to Reproduce

  1. Clean profile, launch with staging, enable rewards and claim grant
  2. Open https://www.reddit.com/user/jsadler-brave
  3. Tip the publisher
  4. Click the tweet button from the thank you area of the banner
  5. On Twitter page open Brave Panel

Actual result:

Panel shows info for previous tab (reddit/jsadler)
Screen Shot 2020-04-10 at 9 18 19 AM

Expected result:

panel should show twitter:
Screen Shot 2020-04-10 at 9 24 46 AM

Reproduces how often:

Doesn't always happen, seems to be about 50% of the time

Brave version (brave://version info)

Brave 1.9.15 Chromium: 81.0.4044.92 (Official Build) nightly (64-bit)
Revision 32921c79b6f01a0fb2deef0e1d45b42f96581051-refs/branch-heads/4044@{#883}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? unsure
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @brave/legacy_qa

@emerick
Copy link
Contributor

emerick commented Oct 9, 2020

We just need to add /intent/ to the list of excluded pages in our Twitter Greaselion script.

@urbenlegend
Copy link

urbenlegend commented Feb 8, 2021

This isn't just happening on Twitter. The wrong publisher is also displayed when simply browsing random posts on the Brave subreddit.
image
You can see that posts are randomly attributed to CryptoJennie.

Is this the same bug?

@LaurenWags
Copy link
Member Author

@urbenlegend I think you're seeing #12302

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 14, 2022

stale

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants