Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress Brave ad notifications when WebRTC is active #9243

Closed
jonathansampson opened this issue Apr 15, 2020 · 3 comments
Closed

Suppress Brave ad notifications when WebRTC is active #9243

jonathansampson opened this issue Apr 15, 2020 · 3 comments
Assignees
@tmancey
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality

Comments

@jonathansampson
Copy link
Contributor

Description

Feature Request: Allow users to optionally disable ad notifications while camera and/or microphone are in use. This feature could inadvertently distract the conference participant, or cause audio to bleed into the call.

Miscellaneous Information:

Suggested by a user on Twitter.

image
@metal3d metal3d mentioned this issue Jun 9, 2020
Closed
@tmancey tmancey added OS/Desktop needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. suggestion and removed feature-request labels Aug 5, 2020
@srirambv srirambv changed the title Suspend Ad Notifications While Conferencing [Desktop] Suspend Ad Notifications While Conferencing Sep 9, 2020
@tmancey tmancey changed the title [Desktop] Suspend Ad Notifications While Conferencing Suspend Ad Notifications While Conferencing Dec 5, 2020
@tmancey tmancey removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Jul 30, 2021
@tmancey
Copy link
Contributor

tmancey commented Jul 30, 2021

We should investigate suppressing ad notifications if there is any active WebRTC

@tmancey tmancey changed the title Suspend Ad Notifications While Conferencing Suppress Brave ad notifications when WebRTC is active Jul 30, 2021
@tmancey tmancey added enhancement QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude and removed suggestion labels Jul 30, 2021
@tmancey tmancey added OS/Android Fixes related to Android browser functionality and removed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Oct 26, 2021
@tmancey tmancey added OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality labels Feb 15, 2022
@tmancey tmancey removed the blocked label Jun 14, 2023
@tmancey tmancey added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. blocked labels Jun 14, 2023
@tmancey tmancey removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. blocked labels Jun 14, 2023
@tmancey
Copy link
Contributor

tmancey commented Jun 14, 2023

Discussed and it was agreed we should not show ads based on the above for both native and custom push notifications

@tmancey
Copy link
Contributor

tmancey commented Oct 24, 2023

Closing issue as will be investigated as part of #33874

@tmancey tmancey closed this as completed Oct 24, 2023
@tmancey tmancey added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Oct 24, 2023
@tmancey tmancey self-assigned this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathansampson @tmancey