Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/u issues for super referral service #9289

Open
1 of 2 tasks
simonhong opened this issue Apr 17, 2020 · 0 comments
Open
1 of 2 tasks

F/u issues for super referral service #9289

simonhong opened this issue Apr 17, 2020 · 0 comments
Assignees
@simonhong
Labels
dev-concern

Comments

@simonhong
Copy link
Member

simonhong commented Apr 17, 2020 •
edited by bsclifton
Loading

  • Make url path more general - We use different url path for SI/SR like chrome://branded-wallpaper/sponsored-images/... or chrome://branded-wallpaper/super-referrals/.... Instead of using SI/SR specific strings in the path, embedding component id would be much better.

  • Remove SR component caching - Currently, we cache to make assets available faster and make favicon available after campaign termination. Find the way to achieve this w/o caching. (FIXED WITH Make top sites work like Chromium brave-core#6584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
dev-concern
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonhong