Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create Get Started section in settings #960

Closed
rebron opened this issue Sep 4, 2018 · 3 comments · Fixed by brave/brave-core#1909
Closed

create Get Started section in settings #960

rebron opened this issue Sep 4, 2018 · 3 comments · Fixed by brave/brave-core#1909
Assignees
Labels
browser-laptop-parity feature/global-settings Settings at browser level independent of shields settings priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 4, 2018

Test plan

  1. Open brave://settings
  2. Very top section should be Get Started
  3. Items should more or less match the description below (New tab page shows is not done yet- needs to be tracked in Add new tab page settings #2999)
  4. Verify Get Started is in the sidebar nav

Description

Create new Get Started section in Settings as the top item.
Label section - 'Get Started'
Label in sidebar - 'Get Started'

This section will include access to Import, Default Browser, New tab page, and On Startup settings.
See design spec.

  1. Selecting Import will take you to Import dialog window.
  2. Move Default browser setting here. Default Browser will show 'Make Default' button if Brave is not default browser. Display ‘Brave is your default browser’ if Brave has been made the default browser.
  3. Create new setting 'New tab page shows' with drop down menu:
    a) Dashboard with images
    b) Homepage
    c) Default search engine
    d) Blank page
  4. Move 'On startup' to this section w/ Brave styling.

Design

@rebron rebron changed the title create Get Started section in Settings create Get Started section in settings Sep 4, 2018
@rebron rebron added this to the 1.0 milestone Sep 4, 2018
@rebron rebron added the feature/global-settings Settings at browser level independent of shields settings label Sep 5, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@srirambv
Copy link
Contributor

+1 from @dfmabbas via #2967 for changing new tab

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 15, 2019
@rebron
Copy link
Collaborator Author

rebron commented Jan 17, 2019

Created #2999. At minimum for this issue, need import, default browser, and on start up in this section; a regrouping of existing items into this section and styling of those items.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@bsclifton bsclifton removed their assignment Mar 19, 2019
@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 19, 2019
@LaurenWags
Copy link
Member

LaurenWags commented May 17, 2019

Verified passed with

Brave 0.65.95 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
  • Verified test plan from description
  • Verification passed on
Brave 0.65.95 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Verification passed on

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS
  • Verified test plan from description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity feature/global-settings Settings at browser level independent of shields settings priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants