Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocationBar colors don't change immediately between dark and light themes #982

Closed
petemill opened this issue Sep 6, 2018 · 2 comments
Closed

LocationBar colors don't change immediately between dark and light themes #982

petemill opened this issue Sep 6, 2018 · 2 comments
Assignees
@petemill @simonhong
Labels
bug feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@petemill
Copy link
Member

petemill commented Sep 6, 2018

brave/brave-core#407 introduces switching NativeTheme between dark and light when our theme service mode is changed between dark and light. However, this does not change immediately when the user changes between light and dark via preferences. The user must switch tabs before these colors are re-calculated.

Similarly for GetOmniboxColor which is also sync'ed to light and dark choice, though that re-paints when the LocationBar is hovered.

Both should observe the theme mode preference and change immediately.

cc @simonhong who also worked on theme service
@petemill petemill added this to the Releasable builds 0.55.x milestone Sep 6, 2018
@petemill petemill self-assigned this Sep 6, 2018
@petemill petemill mentioned this issue Sep 6, 2018
Merged
11 tasks
@simonhong
Copy link
Member

duplicated with #974?

@simonhong simonhong mentioned this issue Sep 6, 2018
Merged
11 tasks
@simonhong simonhong self-assigned this Sep 6, 2018
@petemill petemill mentioned this issue Sep 6, 2018
Closed
@petemill petemill closed this as completed Sep 6, 2018
@petemill petemill removed this from the Releasable builds 0.55.x milestone Sep 6, 2018
@petemill petemill removed the QA/Yes label Sep 6, 2018
@bbondy bbondy added this to the Releasable builds 0.55.x milestone Sep 9, 2018
@bbondy bbondy added the QA/Yes label Sep 10, 2018
@srirambv srirambv added feature/user-interface All UI related and removed feature/ui labels Sep 18, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Sep 20, 2018 •
edited by srirambv
Loading

Verification Pass with

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

@bbondy bbondy added the QA/Yes label Sep 27, 2018
This was referenced Jun 12, 2019
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 12, 2019
Closed
Closed
Closed
Closed
This was referenced Jun 13, 2019
Closed
Closed
@btlechowski btlechowski mentioned this issue Jun 13, 2019
Closed
@LaurenWags LaurenWags mentioned this issue Jun 13, 2019
Closed
This was referenced Jun 13, 2019
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jun 14, 2019
Closed
@btlechowski btlechowski mentioned this issue Jun 14, 2019
Closed
@dayfuaim dayfuaim mentioned this issue Jun 17, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

@simonhong simonhong

Labels
bug feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
6 participants
@petemill @bbondy @simonhong @srirambv @LaurenWags @btlechowski