From 47e91957ebb5d8df3f6d11597181487fff7a7e80 Mon Sep 17 00:00:00 2001 From: Kevin Kuehler Date: Wed, 21 Jul 2021 12:25:39 -0700 Subject: [PATCH] brave_stats: Change dtoi expiration to 30 days This was requested by the growth team and passed privacy review. Resolves https://github.com/brave/brave-browser/issues/17089 --- browser/brave_stats/brave_stats_updater_params.cc | 2 +- browser/brave_stats/brave_stats_updater_unittest.cc | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/browser/brave_stats/brave_stats_updater_params.cc b/browser/brave_stats/brave_stats_updater_params.cc index 8403c02ab55..c8fe83fef66 100644 --- a/browser/brave_stats/brave_stats_updater_params.cc +++ b/browser/brave_stats/brave_stats_updater_params.cc @@ -23,7 +23,7 @@ namespace brave_stats { base::Time BraveStatsUpdaterParams::g_current_time; bool BraveStatsUpdaterParams::g_force_first_run = false; static constexpr base::TimeDelta g_dtoi_delete_delta = - base::TimeDelta::FromSeconds(14 * 24 * 60 * 60); + base::TimeDelta::FromSeconds(30 * 24 * 60 * 60); BraveStatsUpdaterParams::BraveStatsUpdaterParams( PrefService* stats_pref_service, diff --git a/browser/brave_stats/brave_stats_updater_unittest.cc b/browser/brave_stats/brave_stats_updater_unittest.cc index 99ed3937221..30947d58935 100644 --- a/browser/brave_stats/brave_stats_updater_unittest.cc +++ b/browser/brave_stats/brave_stats_updater_unittest.cc @@ -259,8 +259,8 @@ TEST_F(BraveStatsUpdaterTest, HasDailyRetention) { exploded.day_of_month = 4; EXPECT_TRUE(base::Time::FromLocalExploded(exploded, &dtoi_time)); - // Make first run date 6 days earlier (still within 14 day window) - exploded.day_of_month = 10; + // Make first run date 15 days earlier (still within 14 day window) + exploded.day_of_month = 20; EXPECT_TRUE(base::Time::FromLocalExploded(exploded, ¤t_time)); SetCurrentTimeForTest(dtoi_time); @@ -287,8 +287,8 @@ TEST_F(BraveStatsUpdaterTest, HasDailyRetentionExpiration) { exploded.day_of_month = 4; EXPECT_TRUE(base::Time::FromLocalExploded(exploded, &dtoi_time)); - // Make first run date 14 days earlier (outside 14 day window) - exploded.day_of_month = 18; + // Make first run date a month earlier (outside 30 day window) + exploded.month = 12; EXPECT_TRUE(base::Time::FromLocalExploded(exploded, ¤t_time)); SetCurrentTimeForTest(dtoi_time);