From f4cfe1994bcf5dadf6d43b32dcb0631475ecb69c Mon Sep 17 00:00:00 2001 From: Anthony Tseng Date: Fri, 21 Dec 2018 15:28:24 -0800 Subject: [PATCH] Handle invisible nodes (Nodes under Pending Bookmarks and itself) in bookmarks reducer --- ...r-resources-md_bookmarks-reducers.js.patch | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 patches/chrome-browser-resources-md_bookmarks-reducers.js.patch diff --git a/patches/chrome-browser-resources-md_bookmarks-reducers.js.patch b/patches/chrome-browser-resources-md_bookmarks-reducers.js.patch new file mode 100644 index 00000000000..b9922e45a80 --- /dev/null +++ b/patches/chrome-browser-resources-md_bookmarks-reducers.js.patch @@ -0,0 +1,23 @@ +diff --git a/chrome/browser/resources/md_bookmarks/reducers.js b/chrome/browser/resources/md_bookmarks/reducers.js +index 17ca9e18c8f4635aac2db849cb77886a4c7390dc..184e2f993812d6da4e09890336b2815e86d563f0 100644 +--- a/chrome/browser/resources/md_bookmarks/reducers.js ++++ b/chrome/browser/resources/md_bookmarks/reducers.js +@@ -240,6 +240,9 @@ cr.define('bookmarks', function() { + NodeState.moveBookmark = function(nodes, action) { + const nodeModifications = {}; + const id = action.id; ++ // Skip when new/old parent is invisible (Pending Bookmarks) ++ if (!nodes[action.oldParentId] || !nodes[action.parentId]) ++ return nodes; + + // Change node's parent. + nodeModifications[id] = +@@ -414,7 +417,7 @@ cr.define('bookmarks', function() { + return FolderOpenState.openFolderAndAncestors( + folderOpenState, nodes[action.id].parentId, nodes); + case 'move-bookmark': +- if (!nodes[action.id].children) ++ if (!nodes[action.id] || !nodes[action.id].children) + return folderOpenState; + + return FolderOpenState.openFolderAndAncestors(