From 42ee9d630807499fb5378636ac7f117ce9e5e0f1 Mon Sep 17 00:00:00 2001 From: Simon Hong Date: Thu, 30 Aug 2018 08:02:08 +0900 Subject: [PATCH] Fix unittest fail on release BraveThemeService should skip oversing kBraveThemeType prefs because it is not registered in unittest. --- browser/themes/brave_theme_service.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/browser/themes/brave_theme_service.cc b/browser/themes/brave_theme_service.cc index 8a4de705870e..9ae13accb06f 100644 --- a/browser/themes/brave_theme_service.cc +++ b/browser/themes/brave_theme_service.cc @@ -45,11 +45,14 @@ BraveThemeService::BraveThemeService() {} BraveThemeService::~BraveThemeService() {} void BraveThemeService::Init(Profile* profile) { - brave_theme_type_pref_.Init( + // In unittest, kBraveThemeType isn't registered. + if (profile->GetPrefs()->FindPreference(kBraveThemeType)) { + brave_theme_type_pref_.Init( kBraveThemeType, profile->GetPrefs(), base::Bind(&BraveThemeService::OnPreferenceChanged, base::Unretained(this))); + } ThemeService::Init(profile); }