From d32933447270978e814e9c2312fe9eae94b423d3 Mon Sep 17 00:00:00 2001 From: yan Date: Thu, 15 Jun 2017 13:31:49 -0700 Subject: [PATCH] Revert "Use fast-url-parser" This reverts commit 7b0f7d59aa1979707e0f47b9d7f9f92a262b53fd. --- app/common/urlParse.js | 20 ++------------------ package.json | 1 - 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/app/common/urlParse.js b/app/common/urlParse.js index 1418f0df3b8..7a73333d69c 100644 --- a/app/common/urlParse.js +++ b/app/common/urlParse.js @@ -3,7 +3,7 @@ * You can obtain one at http://mozilla.org/MPL/2.0/. */ const LRUCache = require('lru-cache') -const urlParse = require('fast-url-parser').parse +const urlParse = require('url').parse const config = require('../../js/constants/config') let cachedUrlParse = new LRUCache(config.cache.urlParse) @@ -14,23 +14,7 @@ module.exports = (url, ...args) => { return Object.assign({}, parsedUrl) } - // In fast-url-parser href, port, prependSlash, protocol, and query - // are lazy so access them. - const raw = urlParse(url, ...args) - parsedUrl = { - auth: raw.auth, - hash: raw.hash, - host: raw.host, - hostname: raw.hostname, - href: raw.href, - path: raw.path, - pathname: raw.pathname, - port: raw.port, - protocol: raw.protocol, - query: raw.query, - search: raw.search, - slashes: raw.slashes - } + parsedUrl = urlParse(url, ...args) cachedUrlParse.set(url, parsedUrl) return parsedUrl } diff --git a/package.json b/package.json index 59c1e028257..dd98626ae00 100644 --- a/package.json +++ b/package.json @@ -93,7 +93,6 @@ "clipboard-copy": "^1.0.0", "electron-localshortcut": "^0.6.0", "electron-squirrel-startup": "brave/electron-squirrel-startup", - "fast-url-parser": "^1.1.3", "file-loader": "^0.8.5", "font-awesome": "^4.5.0", "font-awesome-webpack": "0.0.4",