Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix BEM naming on enabledContent.js #10146

Closed
luixxiul opened this issue Jul 26, 2017 · 1 comment
Closed

Fix BEM naming on enabledContent.js #10146

luixxiul opened this issue Jul 26, 2017 · 1 comment
Assignees
@luixxiul
Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 26, 2017 •
edited
Loading

Test plan

#11525 (comment)

Describe the issue you encountered: update enabledContent.js to our modified BEM style (ref: https://github.com/brave/browser-laptop/blob/master/docs/style.md#defining-our-blocks-elements-and-modifiers).

  • Brave Version (revision SHA): master

  • Extra QA steps:

    1. Open about:preferences#payments
    2. Enable Payments
    3. Make sure the page is loaded without breaking styles

  • Any related issues:
@luixxiul luixxiul added polish Nice to have — usually related to front-end/visual tasks. refactoring/aphrodite labels Jul 26, 2017
@luixxiul luixxiul added this to the 0.20.x (Nightly Channel) milestone Jul 26, 2017
@luixxiul luixxiul self-assigned this Jul 26, 2017
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
8 tasks
This was referenced Jul 30, 2017
Closed
Closed
Merged
@luixxiul luixxiul modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 1, 2017
@luixxiul luixxiul mentioned this issue Aug 8, 2017
Closed
@luixxiul luixxiul changed the title Update enabledContent.js to BEM style Update enabledContent.js to our modified BEM style Sep 11, 2017
@luixxiul luixxiul reopened this Oct 14, 2017
@luixxiul luixxiul mentioned this issue Oct 14, 2017
Merged
8 tasks
@luixxiul luixxiul modified the milestones: 0.21.x (Developer Channel), 0.22.x (Nightly Channel) Oct 14, 2017
@bbondy bbondy modified the milestones: 0.22.x (Nightly Channel), Backlog Oct 25, 2017
@luixxiul luixxiul removed the polish Nice to have — usually related to front-end/visual tasks. label Nov 18, 2017
@luixxiul luixxiul changed the title Update enabledContent.js to our modified BEM style Fix BEM naming on enabledContent.js Nov 18, 2017
@cezaraugusto cezaraugusto modified the milestones: Triage Backlog, 0.22.x (Nightly Channel) Dec 26, 2017
@bbondy bbondy removed this from the 0.22.x (Developer Channel) milestone Feb 25, 2018
@bbondy bbondy added this to the 0.23.x (Nightly Channel) milestone Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 14, 2018 •
edited by LaurenWags
Loading

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified with macOS 10.12.6 using

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

This was referenced Jun 19, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
7 participants
@bbondy @luixxiul @cezaraugusto @bsclifton @srirambv @LaurenWags @btlechowski