Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Site added instantly to the ledger #10955

Closed
NejcZdovc opened this issue Sep 14, 2017 · 1 comment
Closed

Site added instantly to the ledger #10955

NejcZdovc opened this issue Sep 14, 2017 · 1 comment

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Sep 14, 2017

Test plan

  1. Open about:preferences#payments
  2. Enable Payments
  3. Visit a site
  4. Switch the tab to payments immediately (within 8 seconds)
  5. Make sure that site is not listed there

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Site is added instantly to the ledger, minimum visit time is not used.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    b0d7fc0

  • Steps to reproduce:

    1. go to payments and enable it
    2. visit a site and switch to payments immediately
  • Actual result:
    image

  • Expected result:
    site should be added only after 8s on that site

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 14, 2017
@srirambv
Copy link
Collaborator

I think this is same as #10036

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Sep 14, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel) Sep 19, 2017
@NejcZdovc NejcZdovc mentioned this issue Sep 26, 2017
27 tasks
@luixxiul luixxiul added QA/test-plan-specified release-notes/exclude and removed needs-info Another team member needs information from the PR/issue opener. labels Oct 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.