Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave not asking for permissions when loading geolocations #11036

Closed
srirambv opened this issue Sep 20, 2017 · 5 comments
Closed

Brave not asking for permissions when loading geolocations #11036

srirambv opened this issue Sep 20, 2017 · 5 comments

Comments

@srirambv
Copy link
Collaborator

Description

Brave not asking for permissions when loading geolocations

Steps to Reproduce

  1. Visit https://browserleaks.com/geo
  2. Shows location without asking for permission

Actual result:
Location shown without permission

Expected result:
Should ask permisiom before showing location

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

Brave 0.19.7
rev c8481a9
Muon 4.4.16

Additional Information

#10864

@luixxiul
Copy link
Contributor

Reproduced on Debian. See #10864 (comment) for platform info.

@luixxiul
Copy link
Contributor

@srirambv since the issue is not fixed or decided yet this issue should be excluded from the release note (even though this is release/blocking), I removed the release-notes/exclude label in case. Let's re-add it after it is fixed later.

@NejcZdovc
Copy link
Contributor

this will be fixed with #10896

@srirambv
Copy link
Collaborator Author

#9451 Fails because of this.

@bbondy
Copy link
Member

bbondy commented Sep 20, 2017

Fixed by this merge, but please re-test it on the per issue testing since it had to wait to land:
#10864

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants