Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Upgrade to 1Password 4.6.11.91 #11461

Closed
6 tasks done
jonathansampson opened this issue Oct 11, 2017 · 3 comments
Closed
6 tasks done

Upgrade to 1Password 4.6.11.91 #11461

jonathansampson opened this issue Oct 11, 2017 · 3 comments
Labels
feature/extensions QA/no-qa-needed QA/test-plan-specified

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Oct 11, 2017 •
edited
Loading

Brave currently supports 1Password 4.6.7.90. This issue proposes upgrading to 1Password 4.6.11.91.

Test results with 1Password 4.6.11.91:

  • Clicking browser action icon invokes extension logic
  • Context menu is populated, and responds
  • Credentials are found
  • Site forms are filled/submitted automatically
  • New passwords can be generated
  • Able to login (browser action opens welcome page, which refreshes ad nauseam)

The above issue is (partially?) triggered by the attempt to remove a non-existing element from the <body> element. When stepping around this throw, you may briefly see an attempt to open an external application. This window is quickly dismissed, as the page which invokes it is still caught-up in a self-refresh cycle.

Resolved: The user must have the native client installed beforehand

image
@jonathansampson
Copy link
Collaborator Author

Closed by brave/vault-updater@328d74b.

@luixxiul luixxiul added this to the 0.19.x (Beta Channel) milestone Oct 12, 2017
This was referenced Oct 12, 2017
Closed
Closed
Closed
@bsclifton
Copy link
Member

@luixxiul this is not specific to 0.19.x; it was released globally (existing users now have this). Removing milestone

@bsclifton bsclifton removed this from the 0.19.x (Beta Channel) milestone Oct 12, 2017
@kjozwiak
Copy link
Member

Added the QA/no-qa-needed label as this has already been pushed and is live.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/extensions QA/no-qa-needed QA/test-plan-specified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonathansampson @kjozwiak @luixxiul @bsclifton