Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove CoinMarketCap Empty Elements #12755

Closed
jonathansampson opened this issue Jan 20, 2018 · 3 comments
Closed

Remove CoinMarketCap Empty Elements #12755

jonathansampson opened this issue Jan 20, 2018 · 3 comments
Assignees
@jonathansampson
Labels
feature/adblock QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include site-bug webcompat
Milestone
0.20.x (Release C...

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Jan 20, 2018 •
edited by bsclifton
Loading

Test plan

See #12756

Description

Ad removal on CoinMarketCap leaves empty elements.

Steps to Reproduce

Navigate to coinmarketcap.com, and note spaces.

Actual result:
Large empty regions remain.

Expected result:
Large empty regions should be collapsed when ads are removed (when appropriate)

Reproduces how often:
100%

Brave Version

0.19.139

about:brave info:

Brave: 0.19.139 
rev: 99aa17da28e040543b4ba217d2c4dd6633bf1446 
Muon: 4.7.2 
libchromiumcontent: 64.0.3282.85 
V8: 6.4.388.20 
Node.js: 7.9.0 
Update Channel: Release 
OS Platform: Microsoft Windows 
OS Release: 10.0.16299 
OS Architecture: x64

Reproducible on current live release:
Yes
@jonathansampson jonathansampson mentioned this issue Jan 20, 2018
Merged
7 tasks
@bsclifton bsclifton added this to the 0.20.x (Beta Channel) milestone Jan 21, 2018
This was referenced Jan 22, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

@jonathansampson This is what I'm seeing when using packaged build 0.20.17. Based on the Test Plan (#12756) - I'm still seeing empty spaces on MacOS. Could you take a look?

12755

@LaurenWags LaurenWags reopened this Jan 22, 2018
@srirambv
Copy link
Collaborator

Seeing same on Windows as well

@jonathansampson jonathansampson mentioned this issue Jan 23, 2018
Merged
10 tasks
@kjozwiak
Copy link
Member

Looks good on Ubuntu. I spent some time browsing through CoinMarketCap and I didn't notice any awkward spaces/modals/popups. Examples:

screen shot 2018-01-23 at 11 02 52 pm

screen shot 2018-01-23 at 11 03 40 pm

screen shot 2018-01-23 at 11 12 44 pm

This was referenced Jan 24, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathansampson jonathansampson

Labels
feature/adblock QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include site-bug webcompat
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@jonathansampson @kjozwiak @bsclifton @srirambv @LaurenWags