Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

update tor hashes to version with libevent #14165

Closed
diracdeltas opened this issue May 17, 2018 · 7 comments
Closed

update tor hashes to version with libevent #14165

diracdeltas opened this issue May 17, 2018 · 7 comments

Comments

@diracdeltas
Copy link
Member

diracdeltas commented May 17, 2018

Test Plan

  • download the 0.23.x binary on macOS
  • launch 0.23.x which has Tor integration on macOS via the terminal/console
  • once launched, ensure that Tor service is launched without any issues
  • open a PT tab and enable Tor (ensure DDG/Tor are enabled without issues)
  • visit http://check.torproject.org/ and ensure that Tor is working

Original Issue

depends on brave/tor_build_scripts#4 and @jumde uploading new builds to S3

@diracdeltas diracdeltas added this to the 0.23.x (Developer Channel) milestone May 17, 2018
@darkdh
Copy link
Member

darkdh commented May 17, 2018

closed by #14164

@kjozwiak
Copy link
Member

@diracdeltas @darkdh is there anything that QA can do here? I don't see any information/STR that we could use to check and see if this has been fixed. Seems like #14164 doesn't have much information either. If there's nothing that QA can do here, lets remove the QA/test-plan-required tag and replace it with QA/no-qa-needed.

@darkdh
Copy link
Member

darkdh commented Jun 20, 2018

I added QA/no-qa-needed. as long as you can successfully launch tor in Mac, it is verified.
It used to show libevent not found error because of dynamic link and not everyone has the library installed on their Mac so we can't make that assumption. The fix is to static link libevent into tor binary.

@kjozwiak
Copy link
Member

Thanks @darkdh, going to quickly add a test plan in the original comment and mark this as QA/test-plan-specified & OS/macOS.

@kjozwiak
Copy link
Member

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.11 6565c06
  • muon: 7.1.0
  • libchromiumcontent: 67.0.3396.87

Ensured that the Tor service started without any issues, example:

Kamils-MBP:browser-laptop kjozwiak$ /Applications/Brave-Beta.app/Contents/MacOS/Brave-Beta
Crash reporting enabled
Jun 20 12:21:28.023 [notice] Tor 0.3.3.6 (git-7dd0813e783ae16e) running on Darwin with Libevent 2.1.8-stable, OpenSSL 1.0.2o, Zlib 1.2.11, Liblzma N/A, and Libzstd N/A.
Jun 20 12:21:28.024 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Jun 20 12:21:28.025 [notice] Configuration file "/nonexistent" not present, using reasonable defaults.
Jun 20 12:21:28.033 [notice] Scheduler type KISTLite has been enabled.
Jun 20 12:21:28.033 [notice] Opening Socks listener on 127.0.0.1:9260
Jun 20 12:21:28.034 [notice] Opening Control listener on 127.0.0.1:0
Jun 20 12:21:28.034 [notice] Control listener listening on port 58338.
tor: daemon listens on 127.0.0.1:9260
tor still not ready
Tor ready!

@LaurenWags
Copy link
Member

Verified on macOS 10.12.6 using

  • 0.23.11 6565c06
  • Muon 7.1.0
  • libchromiumcontent 67.0.3396.87

Laurens-MacBook-Pro:~ laurenwagner$ /Users/laurenwagner/BraveDocuments/Laptop/Brave\ Beta/Brave-Beta.app/Contents/MacOS/Brave-Beta
/Library/Caches/com.apple.xbs/Sources/AppleGVA/AppleGVA-10.1.17/Sources/Slices/Driver/AVD_loader.cpp: failed to get a service for display 4
Crash reporting enabled
Jun 20 12:25:15.469 [notice] Tor 0.3.3.6 (git-7dd0813e783ae16e) running on Darwin with Libevent 2.1.8-stable, OpenSSL 1.0.2o, Zlib 1.2.8, Liblzma N/A, and Libzstd N/A.
Jun 20 12:25:15.469 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Jun 20 12:25:15.470 [notice] Configuration file "/nonexistent" not present, using reasonable defaults.
Jun 20 12:25:15.484 [notice] Scheduler type KISTLite has been enabled.
Jun 20 12:25:15.485 [notice] Opening Socks listener on 127.0.0.1:9260
Jun 20 12:25:15.485 [notice] Opening Control listener on 127.0.0.1:0
Jun 20 12:25:15.485 [notice] Control listener listening on port 63595.
tor: daemon listens on 127.0.0.1:9260
tor still not ready
2018-06-20 12:25:17.609 Brave-Beta Helper[25939:1634249] Couldn't set selectedTextBackgroundColor from default ()
Tor ready!

@kjozwiak
Copy link
Member

kjozwiak commented Jun 22, 2018

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.12 88f6f07
  • muon: 7.1.1
  • libchromiumcontent: 67.0.3396.87

Ensured that the Tor service started without any issues, example:

Kamils-MBP:~ kjozwiak$ /Applications/Brave-Beta.app/Contents/MacOS/Brave-Beta
Crash reporting enabled
Jun 22 00:03:59.016 [notice] Tor 0.3.3.7 (git-035a35178c92da94) running on Darwin with Libevent 2.1.8-stable, OpenSSL 1.0.2o, Zlib 1.2.11, Liblzma N/A, and Libzstd N/A.
Jun 22 00:03:59.016 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Jun 22 00:03:59.016 [notice] Configuration file "/nonexistent" not present, using reasonable defaults.
Jun 22 00:03:59.019 [notice] Scheduler type KISTLite has been enabled.
Jun 22 00:03:59.019 [notice] Opening Socks listener on 127.0.0.1:9260
Jun 22 00:03:59.020 [notice] Opening Control listener on 127.0.0.1:0
Jun 22 00:03:59.020 [notice] Control listener listening on port 52227.
tor: daemon listens on 127.0.0.1:9260
tor still not ready
Tor ready!

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87
Jun 25 09:11:48.047 [notice] Tor 0.3.3.7 (git-035a35178c92da94) running on Windows 8 with Libevent 2.1.8-stable, OpenSSL 1.0.2o, Zlib 1.2.11, Liblzma N/A, and Libzstd N/A.
Jun 25 09:11:48.154 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Jun 25 09:11:48.276 [notice] Configuration file "C:\nonexistent" not present, using reasonable defaults.
Jun 25 09:11:48.318 [warn] Path for GeoIPFile (<default>) is relative and will resolve to C:\Users\srirambv\AppData\Local\Brave\app-0.23.16\<default>. Is this what you wanted?
Jun 25 09:11:48.347 [warn] Path for GeoIPv6File (<default>) is relative and will resolve to C:\Users\srirambv\AppData\Local\Brave\app-0.23.16\<default>. Is this what you wanted?
Jun 25 09:11:48.350 [notice] Scheduler type KISTLite has been enabled.
Jun 25 09:11:48.350 [notice] Opening Socks listener on 127.0.0.1:9250
Jun 25 09:11:48.350 [notice] Opening Control listener on 127.0.0.1:0
Jun 25 09:11:48.350 [notice] Control listener listening on port 52678.
Jun 25 09:11:48.000 [notice] Bootstrapped 0%: Starting
Jun 25 09:11:49.000 [notice] Starting with guard context "default"
Jun 25 09:11:49.000 [notice] Bootstrapped 80%: Connecting to the Tor network
Jun 25 09:11:49.000 [notice] New control connection opened from 127.0.0.1.
Jun 25 09:11:50.000 [notice] Bootstrapped 85%: Finishing handshake with first hop
Jun 25 09:11:50.000 [notice] Bootstrapped 90%: Establishing a Tor circuit
Jun 25 09:11:51.000 [notice] Tor has successfully opened a circuit. Looks like client functionality is working.
Jun 25 09:11:51.000 [notice] Bootstrapped 100%: Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.