-
Notifications
You must be signed in to change notification settings - Fork 974
Window off screen when monitors change #3558
Comments
I wasn't able to reproduce this with v0.11.6 on Linux. Maybe it is windows only issue and maybe it is related to #3543 . I was never able to see a negative value for display position when moving the brave window to the second display, even if I tried to move the second display on the left or on the right and then shutdown the OS. This need to be tested on Windows however to confirm that and maybe on macOS as well. Edit: Even if I manage to set a negative value to the |
This issue may happen w/ mirrored also, cc: @BrendanEich |
I ran into this issue today as well, and resolve in the same manner. Somehow, my configuration was set to create a 960px-wide window, at more than -1400px off the screen. This may have something to do with my hi-DPI Surface Book being attached to my standard-DPI external monitor. For now, I suspect a straight-forward fix/patch would be to calculate whether or not the window will be visible (given its dimensions, and offset). In the event that it isn't, default to 0, or some calculated offset that factors in the window index (1 is 0px, 2 is 10px, etc). |
It sounded like this issue was mostly solved with #7396, there were just a few things which needed to be worked out 😄 Assigned over to @jonathansampson |
I don't have a fix at this time, but switching your primary display temporarily appears to resolve the positioning. I connect a secondary monitor, and thus change my primary display from time to time. This apparently yields the undesired behavior above. Temporary Work-around:
Alternative Work-around
|
@bsclifton is ok to pull this into 0.20.x, because I already worked on #10458 and #10580 in 0.20.x and I have a fix for this one as well? |
now that I think about it, maybe #10458 will fix this automatically. @jonathansampson I see that you can reproduce this problem, can you please checkout #10458 and see if this was fixed? Thank you |
@NejcZdovc let's do it 😄 👍 Assigning to 0.20.x |
@brave/qa can you please retest this with the latest master? Thank you |
I tried this with the latest master and if I set values to |
Is the fix for this issue in version 0.18.36? I can still reproduce this issue on Windows 10 with the latest release of Brave: Brave: 0.18.36 |
@bryan-learn this will be fixed in release 0.20.x |
Happened to me for the first time right now. Tried the temporary fix but did not work. Tried the alternative workaround but was not able to find the word "position" in session-store-1 at all. |
@bblaha Temporarily setting a new main screen should resolve the issue. If it does not, we can hop on a Skype/Hangout call together (at your convenience) to take a closer look. |
With v0.19.53, "position":[x,y] does not exist. Instead I've found the current keys for ui positioning in 0.19.53: |
Verified as fixed on Windows. Open Brave beta 0.20.16. Moved to extended display,reboot machine and launch brave-beta opens properly on extended display |
This seems to have cropped up for me again on Windows 21.18. I can't find the session store file anymore to fix it either, so the browser is currently only usable in full screen. Edit: was able to find the session file now, was in the wrong Brave folder in App Data (apparently both Local and Roaming have Brave files). |
@shortstuffsushi would you mind creating a new issue if you're still seeing this happen and reference this one? |
Test plan
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Note: I've experienced this issue before.
When opening Brave, I could not locate the
ui
window.Expected behavior:
When Opening brave, I should be able to see the
ui
window.Win 10
ui
windowRelated Symptoms for bug squashing:
To fix this issue temporarily, I did the following.
1.went to
C:/Users/{username}/AppdData/Roaming/brave
2.opened
session-store-1
in a text editor3.saw this json:
4.I changed the
ui.position
from [-15244, 7] to [0, 7]5,Now when opening brave, I could see the
ui
windowI have experienced something similar on Chrome(desktop on windows) in the past.
Maybe doing a check on the
ui.position
and making sure it isn't out of some sort of pre-defined range. If it is out of range, then set it to 0 on start.-Al
The text was updated successfully, but these errors were encountered: