Brave payments: Line should always appear when user scroll down

[bitcoinuser]

Hi,

I think this line on brave payments should always appear when user scroll down.

[mrose17]

@jkup - fyi: this probably should be dealt with at the same time as we deal with #3792

[jkup]

@bsclifton I think you had some good feedback about this table in chat somewhere but I can't find it. Was it lacking keyboard navigation or something?

[bsclifton]

@jkup Yes! the scrollbar was on the table itself, not on the window. So it wasn't straightforward to scroll through the list (especially without a mouse)

Was able to solve of course by clicking inside that area then scrolling (using gestures or arrow keys)

[jkup]

@bsclifton ah yes! ok great, I'll add that work to this ticket. Thanks.

[bradleyrichter]

this solution doesn't seem to be working well enough

• the nested scroll bar now doesn't extend to the bottom of the main window
• the top of the scroll bar is cropped

@jkup Can we instead float the entire top area including the list header row and then use the entire window for scrolling?

[jkup]

@bradleyrichter yeah I mean this is working as expected with the CSS hack I added to make the headers sticky. I agree that it would look much nicer if we didn't set a max-height on the list and just let the window scroll. Should I make a new issue for this? Either way I can get it in this week.

[bradleyrichter]

Sure. Close and make a new issue if you prefer.

On Oct 4, 2016, at 8:42 PM, Jon Kuperman notifications@github.com wrote:

@bradleyrichter yeah I mean this is working as expected with the CSS hack I added to make the headers sticky. I agree that it would look much nicer if we didn't set a max-height on the list and just let the window scroll. Should I make a new issue for this? Either way I can get it in this week.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[bbondy]

Reclosing but pls do a new issue since the change would be in 0.12.5 and this is in 0.12.4.