Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Show tabs in page theme color not working #4683

Closed
bsclifton opened this issue Oct 11, 2016 · 1 comment
Closed

Show tabs in page theme color not working #4683

bsclifton opened this issue Oct 11, 2016 · 1 comment

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 11, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Somewhere along recent commits, the "Show tabs in page theme color" feature stopped working as intended. It now seems to show the theme color as an outline over the webframe

Expected behavior:
Tab should be the color

  • Platform (Win7, 8, 10? macOS? Linux distro?):
  • Brave Version:
    0.12.4
  • Steps to reproduce:
    1. Launch Brave and visit https://duckduckgo.com
    2. Visit preferences > tabs, make sure you have "Show tabs in page theme color" enabled
    3. Check tab- it should be orange. Instead, you'll see an orange outline over the webframe
  • Screenshot if needed:
    screen shot 2016-10-11 at 12 22 02 pm
  • Any related issues:
    possibly Minor toolbar visual refinement suggestions #4400
@bsclifton bsclifton added this to the 0.12.5dev milestone Oct 11, 2016
@bsclifton
Copy link
Member Author

I believe I was mistaken when opening this... other sites seem to work OK after retesting. Closing out

@bsclifton bsclifton removed this from the 0.12.5dev milestone Oct 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant