Characters fall off if URL is autocompleted on the URL bar

[luixxiul]

Describe the issue you encountered: On the latest master, if history entries are found and autocompleted, some characters on URL bar fall off if you type them fast, like “github” -> “gihub".

Expected behavior: They should not fall off.

• Platform (Win7, 8, 10? macOS? Linux distro?): OS X
• Brave Version: https://github.com/brave/browser-laptop/tree/f9f9bffc6465d28d3dbfc7e4869482ff0d9c72ba
• Steps to reproduce:
  1. Go to https://github.com/brave/ and https://github.com/brave/browser-laptop
  2. Open a new tab
  3. Type "github" fast
• Any related issues:

Please set a milestone if necessary.

[bbondy]

cc @diracdeltas

[luixxiul]

Also the autocomplete pulldown flickers if another github page has been bookmarked.

[diracdeltas]

@luixxiul did you test this after pulling f9f9bff?

[diracdeltas]

@luixxiul never mind comment above, i just saw you included the version in the issue

[Sh1d0w]

This is still happening from time to time for me on 0.12.5-RC1. I am not sure how to reproduce 100% but it happened several times with the following pattern:

1. I have opened new tab as usual
2. Started typing url of a website I often visit (I was not typing fast, just with a normal speed)
3. After I wrote the domain name before the . and started typing .com the characters started to erase and I had to type them twice. Even after I typed the whole address before I hit enter I deleted the ..com part and started typing it again, again characters were dissapearing so it was 100% reproducible.
4. I closed that tab without navigating to the address and opened new tab again. After that the issue was not reproducible

I thought it was something not worth to mention but happened twice more times this morning.

Brave version: 0.12.5-RC1
OS: Fedora 24

Edit: after some usage of the browser it is almost 100 % reproducible if you type fast as described in the original issue above.

[Sh1d0w]

Here is a video. I typed random chars, that even do not autocomlete and still lossing chars.

Typed waywwad, result in the url bar was waywwd - http://webm.land/media/cZYK.webm

PS. The video is taken after update to 0.12.5-RC2

I thnik the problem is not in the UrlBar suggestions, rather than race condition between onKeyDown and onChange events here https://github.com/brave/browser-laptop/blob/master/js/components/urlBar.js#L40 , because onKeyDown is bound to keydown event and onChange is bound on keyup event ... https://github.com/brave/browser-laptop/blob/master/js/components/urlBar.js#L450

I think the onChange event needs to be dobunced as well and that will solve the problem.

cc @diracdeltas

[bbondy]

would like to get this in 0.12.6 if possible

[bbondy]

Moving to 0.12.6

[diracdeltas]

please try out the fix in 2c5a369. it seems that characters are only lost when the in-place autocomplete happens as a key is being pressed, so i just changed it so that autocomplete never happens while a key is pressed.

[Sh1d0w]

@diracdeltas Just builded it and installed. Good job, seems it is working correctly now 👍