Advanced setting button should be hidden when payments is disabled

[Sh1d0w]

Did you search for similar issues before submitting this one?

No.

Describe the issue you encountered:
Clicking on the "Advanced settings" button while payments are turned off produces no action. If you turn payments on then a pop up appears.

Expected behavior:

When payments are off, the button should be hidden, if it will not trigger any action.

• Platform (Win7, 8, 10? macOS? Linux distro?): All
• Brave Version: 0.12.5-1
• Steps to reproduce:
  1. Go to payments
  2. Turn them off
  3. Click advanced settings
• Screenshot if needed:
  
• Any related issues:

[luixxiul]

I cannot confirm this was fixed on 0.12.5 RC2, on Windows 10. Regression or something?

[bbondy]

This is not in 0.12.5 but it should be fixed on master 0.12.6.
By the way you can see the tags it is on by clicking on the commit, the one we do builds from is dev-channel.

[luixxiul]

I thought this is it, which has been tagged 0.12.5 RC builds: 7666907

[bsclifton]

ah- definitely my bad assuming it was pulled into 0.12.5

[luixxiul]

This is happening again on the latest master.

[bsclifton]

@luixxiul can you open a new issue w/ steps to reproduce? (and link back here) Thanks 😄