Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Exclude pattern to block brave ad replacement placeholder from adblock filters #4816

Closed
luixxiul opened this issue Oct 15, 2016 · 1 comment
Closed

Exclude pattern to block brave ad replacement placeholder from adblock filters #4816

luixxiul opened this issue Oct 15, 2016 · 1 comment
Labels
feature/adblock QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.5dev

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: Currently there are some regional adblock filters block brave ad replacement placeholder.

Expected behavior: Exclude pattern to block brave ad replacement placeholder from adblock filters.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.5 RC1
  • Steps to reproduce:
    1. Open https://slashdot.org and confirm "Show Brave ads" is selected on the bravery shield
    2. Open about:adblock and enable JPN: ABP Japanese filters (日本用フィルタ)
    3. Clear cache and reload https://slashdot.org
    4. Placeholders are gone
  • Any related issues:
@luixxiul luixxiul added this to the 0.12.5dev milestone Oct 15, 2016
@luixxiul luixxiul mentioned this issue Oct 15, 2016
Closed
@bbondy
Copy link
Member

bbondy commented Oct 15, 2016

Fixed here:
brave-experiments/ad-block@9d92106

@bbondy bbondy closed this as completed Oct 15, 2016
This was referenced Oct 16, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Oct 18, 2016
Closed
102 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/adblock QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.5dev
Development

No branches or pull requests
4 participants
@bbondy @alexwykoff @luixxiul @srirambv