Selecting and Cutting the UrlBar text reverts the text back

[Sh1d0w]

Did you search for similar issues before submitting this one?

No

Describe the issue you encountered:

Selecting and cutting the whole url in the url bar restores it back.

Expected behavior:

The url bar should remain empty

• Platform (Win7, 8, 10? macOS? Linux distro?): Linux
• Brave Version: 497ecf8
• Steps to reproduce:
  1. Open a website
  2. Hit CTRL+L -> CTRL+A -> CTRL+X
  3. Observe the text you have just cut restores back.
• Screenshot if needed:
• Any related issues:
  Navigating to URL causes UrlBar to "blink" and yield wrong url results #4219

[privatzee]

same W7x64

[diracdeltas]

can't seem to repro on mac with CMD+L, CMD+A, CMD+X

[Sh1d0w]

@diracdeltas It seems it's Linux and Windows issue only then. Here is a video: http://webm.land/media/YLmC.webm

[bbondy]

@alexwykoff @srirambv @luixxiul can you reproduce?

[alexwykoff]

works on os x

[alexwykoff]

works on ubuntu as well

[Sh1d0w]

@alexwykoff Are you following the STR in the video http://webm.land/media/YLmC.webm and the original issue as described? It is very strange because I updated to 0.12.6-Preview 2 this morning and I can still reproduce the problem:

1. Open a website
2. CTRL+L
3. CTRL+A
4. CTRL+X
5. The text reverts back

We have another user who confirmed this, so it can't be just me :(

[alexwykoff]

Ah, I was using the context menu. Command+L -> Command+X reproduces the issue. No need for Command+A on mac

[srirambv]

Reproducible on Windows build. Ctrl+A not required as @alexwykoff mentioned.

[Sh1d0w]

@diracdeltas @bbondy I am very sorry to reopen this, but can I ask you to revert the commit. Nice fix, but I am asking because I fixed this as well as several other bugs in general via #5025

@diracdeltas can you review my PR (#5026) and if you decide it is not good enough please leave your commit and close mine.

The PR I have opened fixes 3 things:

1. Wrong behaviour when hitting CTRL+L (as described in the ticket)
2. Wrong suggestions after first character typed in the URL bar
3. The problem with CTRL+L and CTRL+X

Otherwise please move this issue for the next milestone, when my PR can get merged.

[Sh1d0w]

@bbondy Advised me to revert the commit in another branch and to cherry-pick my PR there.

Closing.

[bbondy]

Yep I asked to please revert in another branch, apply his fix, then squash into one for 0.12.7, and then PR it and ask @diracdeltas for review. Thanks!

[Sh1d0w]

For the record here is the new PR:

#5046

[diracdeltas]

@Sh1d0w to avoid duplicate work in the future, please self-assign an issue when you start it. thanks

[Sh1d0w]

@diracdeltas Yes sorry. My attention wasn't to fix this issue in practicular, but it turned out after I fixed the other one this was resolved as well when I tested :)