Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Strings in shields panel need proper pluralization #4966

Closed
bsclifton opened this issue Oct 19, 2016 · 0 comments
Closed

Strings in shields panel need proper pluralization #4966

bsclifton opened this issue Oct 19, 2016 · 0 comments

Comments

@bsclifton
Copy link
Member

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Shields panel should show strings which have grammar matching the count

[ 0 ]  Ads and Trackers Blocked
[ 1 ]   Ad or Tracker Blocked
[ 2+]  Ads and trackers Blocked

[ 0 ]  HTTPS Upgrades
[ 1 ]   HTTPS Upgrade
[ 2+]  HTTPS Upgrades

[ 0 ]  Scripts Blocked
[ 1 ]    Script Blocked
[ 2+]  Scripts Blocked

[ 0 ]   Fingerprinting Methods Blocked
[ 1 ]    Fingerprinting Method Blocked
[ 2+]  Fingerprinting Methods Blocked

Expected behavior:
We should be able to customize the strings when value is 0, 1, or more than 1

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All
  • Brave Version:
    All
  • Steps to reproduce:
    1.
    2.
    3.
  • Screenshot if needed:
  • Any related issues:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants