Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

bookmark cannot be deleted from the panel if location is changed #4978

Closed
luixxiul opened this issue Oct 20, 2016 · 8 comments · Fixed by #9710
Closed

bookmark cannot be deleted from the panel if location is changed #4978

luixxiul opened this issue Oct 20, 2016 · 8 comments · Fixed by #9710

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 20, 2016

Test plan

#9710

Also see STR


Describe the issue you encountered: bookmark cannot be deleted from the panel, if location is changed at the same time.

  • Platform (Win7, 8, 10? macOS? Linux distro?): OS X

  • Brave Version: 0.12.5

  • Steps to reproduce:

    1. Bookmark https://github.com
    2. Edit bookmark from the bookmark toolbar
    3. Add some characters to the location like https://g.nite07.orga (do not save)
    4. Click Remove

Expected Result: The bookmark should be removed

Actual result: The bookmark is not removed

@luixxiul
Copy link
Contributor Author

posting it being not sure if it works as it should.

@srirambv
Copy link
Collaborator

I can't repro the steps. However I did see that the location still shows as Bookmark folder rather than the new location.

@luixxiul
Copy link
Contributor Author

@srirambv did you save the edited location?

@srirambv
Copy link
Collaborator

Yes

@luixxiul
Copy link
Contributor Author

@srirambv will you try without saving it? I forgot to mention it.

@srirambv
Copy link
Collaborator

@luixxiul Yes without saving the bookmark remains in the toolbar.

@luixxiul luixxiul added the bug label Nov 1, 2016
@luixxiul luixxiul added this to the 1.2.0 milestone May 29, 2017
@NejcZdovc
Copy link
Contributor

@luixxiul @srirambv can you please retest this in version 0.19?

@NejcZdovc
Copy link
Contributor

Should be fixed with #9710

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.