Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

window size not remembered after restart #5267

Closed
luixxiul opened this issue Oct 30, 2016 · 10 comments
Closed

window size not remembered after restart #5267

luixxiul opened this issue Oct 30, 2016 · 10 comments
Labels

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: Window size is not remembered after restart.

Expected behavior: it should be remembered.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.8 Preview 1
  • Screenshot if needed:

On the animation below you will notice that the window extends over the Windows toolbar after restart.
window

  • Any related issues:
@luixxiul luixxiul added this to the 0.12.9dev milestone Oct 30, 2016
@luixxiul luixxiul added the bug label Oct 30, 2016
@privatzee
Copy link
Contributor

+1 especially because it can be difficult resizing the top of a Brave window. There are only a few pixels of height wherein the mouse cursor turns into the double arrow resizing cursor. Electron is not that way.

@bsclifton bsclifton removed this from the 0.12.9dev milestone Nov 8, 2016
@bsclifton
Copy link
Member

Removing this from the milestone; let's work with @bradleyrichter or @bbondy if we want to reassign it into a milestone

@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Nov 8, 2016
@bradleyrichter
Copy link
Contributor

This happens every time you close? This is an annoying one. Should be fixed in 1.0.

@bsclifton
Copy link
Member

@bradleyrichter it should have been fixed before- unless something broke that functionality. The size and position are saved. Needs investigation

@bsclifton
Copy link
Member

Should have been fixed with #5102

I wonder if this is very specifically dragging the window until it has a negative x/y coordinate?

@luixxiul I can see the picture, but it's confusing to me; could you type up some steps to reproduce?

@bsclifton
Copy link
Member

@privatzee resizing the top is tracked here 😄 #4782

@luixxiul
Copy link
Contributor Author

luixxiul commented Nov 8, 2016

Yes it has been resolved. I'm not sure what was causing the issue as the issue should have been fixed already as @bsclifton mentioned. Closing.

@luixxiul luixxiul closed this as completed Nov 8, 2016
@luixxiul luixxiul removed this from the 1.0.0 milestone Nov 8, 2016
@bsclifton
Copy link
Member

@luixxiul awesome, thanks for the updated 😄

@draeron
Copy link

draeron commented Mar 11, 2017

this bug should be reopenned, still happening in 0.13.5

possible duplicate : #6602

@luixxiul
Copy link
Contributor Author

could you replicate the issue by removing the profile folder? (please do not forget to create a copy of the folder for later restore)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants