Add bookmark from toolbar/right click context menu brings up "edit bookmark" modal

[srirambv]

Test plan

#9710 (comment)

---

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Add bookmark form toolbar brings up edit bookmark modal

Expected behavior:
Should show "Bookmark added" and show the hanger, not the modal

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version:
  0.12.9 Preview 1
  0.12.8 shows bookmark added modal

• Steps to reproduce:

  1. Enable Bookmark toolbar
  2. Right click, Add boomark, shows edit bookmark modal for the current active tab instead of add new bookmark modal
  3. Click star+ icon from about:bookmark, shows create bookmark modal

• Screenshot if needed:
  

• Any related issues:

  cc: @bsclifton
  Adding 0.12.10 as milestone, please change if required

[srirambv]

Right Click add bookmark from about:bookmark also brings up the edit bookmark modal.

[bbondy]

@jkup would you mind taking this?

[jkup]

@bbondy Yep of course!

[bbondy]

Re-opened for review comment:
#5717 (comment)

[jkup]

@bbondy I read your comment about desired functionality but looking at Chrome it seems like they do exactly what we do (see screenshots) unless I'm still misunderstanding you!

It seems like maybe the thing we need to fix in this ticket is that when you right click in the bookmarks menu and click add bookmark the modal title says "edit bookmark" which isn't right. So maybe the bookmark modal needs a third state which is the Add Bookmark title with the Edit Bookmark ability to change fields.

[bbondy]

@bbondy I read your comment about desired functionality but looking at Chrome it seems like they do exactly what we do (see screenshots) unless I'm still misunderstanding you!

Yes but that's because I reverted it.
I think the way it was in the PR, when you right clicked on the bookmark toolbar and click on add bookmark it wouldn't let you set the location.

[bsclifton]

Moving to contributor backlog and marked as good first bug 😄

[NejcZdovc]

This should be fixed with #9710