Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

transition of every button in #navigator #5664

Closed
luixxiul opened this issue Nov 16, 2016 · 5 comments
Closed

transition of every button in #navigator #5664

luixxiul opened this issue Nov 16, 2016 · 5 comments
Assignees
@luixxiul @cndouglas
Labels
bug design A design change, especially one which needs input from the design team. feature/navbar QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: There is no transition of the reload button. While the URL bar is shown smoothly, the reload button instantly without transition.

reload

Expected behavior: The styling should be consistent.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

  • Brave Version: 0.12.9

  • Any related issues:

CC @bradleyrichter @cezaraugusto
@luixxiul luixxiul added bug design A design change, especially one which needs input from the design team. feature/URLbar labels Nov 16, 2016
@cndouglas
Copy link

Same issue with the home button (if enabled).

@cndouglas cndouglas self-assigned this Nov 16, 2016
@cndouglas cndouglas mentioned this issue Nov 16, 2016
Merged
4 tasks
@cndouglas
Copy link

#5667 fixes the problem for me.

@bsclifton bsclifton added this to the 0.12.11 milestone Nov 19, 2016
This was referenced Dec 12, 2016
Closed
Closed
@luixxiul luixxiul reopened this Dec 20, 2016
@luixxiul
Copy link
Contributor Author

It stopped working because buttons have been changed from <span> to <button>. I will push a fix.

@luixxiul luixxiul mentioned this issue Dec 20, 2016
Merged
4 tasks
@luixxiul luixxiul removed this from the 0.13.0 milestone Dec 20, 2016
@luixxiul luixxiul changed the title transition of reload button transition of every button in #navigator Dec 20, 2016
@luixxiul luixxiul self-assigned this Dec 20, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@bsclifton bsclifton added this to the 0.13.0 milestone Dec 20, 2016
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@bbondy
Copy link
Member

bbondy commented Dec 21, 2016

nice find @luixxiul

@luixxiul
Copy link
Contributor Author

Test Plan:

  1. Open about:preferences
  2. Disable/enable "Always show the URL bar" option

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

@cndouglas cndouglas

Labels
bug design A design change, especially one which needs input from the design team. feature/navbar QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @bsclifton @srirambv @cndouglas