Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Gray footer which contains nothing on the QR code overlay window on about:preferences#payments #5785

Closed
luixxiul opened this issue Nov 22, 2016 · 9 comments
Closed

Gray footer which contains nothing on the QR code overlay window on about:preferences#payments #5785

luixxiul opened this issue Nov 22, 2016 · 9 comments
Assignees
@luixxiul
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring release-notes/include
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Nov 22, 2016 •
edited
Loading

Describe the issue you encountered: If you live outside of the US you get the dark footer which contains nothing on the QR code overlay window on about:preferences#payments

clipboard01

Expected behavior: The less files for a modal overlay and preference page should be much less complex to keep the consistency, including the close button (#5719) alignment. They need refactoring.
@luixxiul luixxiul added design A design change, especially one which needs input from the design team. feature/rewards refactoring labels Nov 22, 2016
@luixxiul luixxiul added this to the 1.0.0 milestone Nov 22, 2016
@luixxiul luixxiul self-assigned this Nov 22, 2016
@srirambv
Copy link
Collaborator

I don't see this on my Windows 10 machine
image

@luixxiul
Copy link
Contributor Author

You get the footers because var coinbaseCountries in coinbaseCountries.js contains IE. It is expected and is working well for you.

@srirambv
Copy link
Collaborator

Shouldn't it not show Coinbase as well since its showing bitcoin source as Cubits for outside US??

@luixxiul
Copy link
Contributor Author

CCing @mrose17 for thoughts

@luixxiul
Copy link
Contributor Author

@srirambv mind opening an issue for that?

@srirambv srirambv mentioned this issue Nov 22, 2016
Closed
@luixxiul luixxiul mentioned this issue Nov 23, 2016
Merged
@luixxiul luixxiul modified the milestones: 0.13.0, 1.0.0 Nov 23, 2016
@luixxiul
Copy link
Contributor Author

Fixed with #5797

@luixxiul luixxiul removed their assignment Nov 23, 2016
@luixxiul
Copy link
Contributor Author

My bad, it is not fixed

@luixxiul luixxiul reopened this Nov 23, 2016
@luixxiul luixxiul removed this from the 0.13.0 milestone Nov 23, 2016
@luixxiul luixxiul mentioned this issue Nov 23, 2016
Closed
@luixxiul luixxiul mentioned this issue Dec 4, 2016
Merged
4 tasks
@bsclifton bsclifton added this to the 0.13.0 milestone Dec 6, 2016
@bsclifton
Copy link
Member

Will be fixed by #6009

This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor Author

Test plan: 21ece29

Test Plan 4:

  1. Disable Coinbase via VPN
  2. Make sure the grey footer no longer appears on the Add funds dialog

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring release-notes/include
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
3 participants
@luixxiul @bsclifton @srirambv