Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Import browser data switches misaligned #5860

Closed
jkup opened this issue Nov 27, 2016 · 5 comments
Closed

Import browser data switches misaligned #5860

jkup opened this issue Nov 27, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@jkup
Copy link
Contributor

jkup commented Nov 27, 2016

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
On the Import Browser Data dialog the switches are not left-aligned.

Expected behavior:
The four switches (pictured) should all be left aligned on the dialog.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version:
    master

  • Steps to reproduce:

    1. Open Brave
    2. Go to Preferences
    3. Click "Import now..."
  • Screenshot if needed:

screen shot 2016-11-27 at 1 41 06 pm

  • Any related issues:
@jkup jkup added design A design change, especially one which needs input from the design team. feature/importer labels Nov 27, 2016
@bsclifton
Copy link
Member

There was a reason for this... but I agree, it looks weird

cc: @bradleyrichter @darkdh

@darkdh
Copy link
Member

darkdh commented Nov 28, 2016

It was intended to indicate merge into toolbar is the sub option of bookmark. And it can only be toggled when bookmark option is active.

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Nov 28, 2016 via email

@jkup
Copy link
Contributor Author

jkup commented Nov 28, 2016

Oh I see. Yeah maybe just pushing it a bit further to the right like @bradleyrichter suggested will help? I'll give it a try and post a screenshot! :)

@luixxiul
Copy link
Contributor

Test plan: #5863 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants