sanitizeTemplateItems should remove first item if it is a separator

[bbondy]

Also please add a test for it.

For example, on linux:

/cc @bsclifton

[siemiatj]

Lookng at the source :

browser-laptop/app/common/lib/menuUtil.js

Line 178 in 35944f6

if (result.length > 0 && result[0] === CommonMenu.separatorMenuItem) {

and tests :

browser-laptop/test/unit/app/common/lib/menuUtilTest.js

Line 276 in 35944f6

it('does not allow the list to start with a separator', function () {

this should already be handled.

Maybe it's a linux thing ? The order of the items seems different if it's the latest build.

[bbondy]

Yes I think it only happens on Linux, each platform has a slightly different menu sometimes.

[bbondy]

it does seem handled from code, interesting. I guess I'd have to dig in deeper on Ubuntu to see why it happened.

[cndouglas]

I can reproduce with Brave 0.12.13 RC 2 on macOS 10.12.x

There is an extra separator here:
https://github.com/brave/browser-laptop/blob/master/app/browser/menu.js#L430

[siemiatj]

I'm wondering if it's not caused by the Search bar that is added for the Help tab. I can't really reproduce this in tests or in any other tab. Creating a PR that removes it.