Editing/Deleting bookmark from toolbar causes the active tab to load the deleted bookmark

[srirambv]

Test plan

• Use Brave on Windows
• Have bookmarks toolbar shown and have a few entries
• Right click any of the links (not folders) in bookmarks toolbars
• Context Menu should pop up. Press ESC or do a left click anywhere on the page to dismiss the context menu
• Link should no longer be followed

Deleting isn't necessary (as was originally pointed out in STR below). The root cause was:

1. Right click showed context menu via onContextMenu
2. onAuxClick fires AFTER onContextMenu (right click is also considered aux click)
3. link is followed before action is taken (whatever was chosen in popup menu (step 1))

Original issue description

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Deleting bookmark from toolbar causes the active tab to load the deleted bookmark

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10

• Brave Version (revision SHA):
  Brave: 0.13.5
  rev: 59a41eb

• Steps to reproduce:

  1. Add a bunch of bookmarks on a clean install of 0.13.5
  2. Open a new tab and delete one of the bookmarks from toolbar
  3. Deleted bookmark page is opened in the active tab

• Actual result:
  Deleted bookmark page is opened in the active tab

• Expected result:
  Should only remove the bookmark and not load the page in active tab

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  Yes. Issue found from 0.13.3 on wards

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  

• Any related issues:

[srirambv]

Basically right click on the bookmark item causes it to open in the current active tab

[bsclifton]

cc: @bbondy (may be related to the aux-click)

[srirambv]

User Jim has reported similar issue on community. https://community.brave.com/t/right-click-bug-opening-tabs/1313. Right click on bookmark item and select open in new tab causes the bookmark to be opened in the active tab and in a new tab.

[srirambv]

This is still an issue on preview 3 but verified and working fine on master