Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed messages shown on extensions page - All Predefined Messages Should Be Replaced #8318

Closed
jonathansampson opened this issue Apr 14, 2017 · 0 comments

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Apr 14, 2017

Test Plan:

Enable the Save to Pocket extension
Ensure that the description does not contain _MSG
Navigate to about:extensions
Ensure that Save to Pocket does not contain references to _MSG for Google Chrome

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Brave currently only looks for three specific values to handle when applying predefined messages in an extension's manifest. This could potentially miss several other keys that also need to be modified.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Desktop

  • Brave Version (revision SHA):
    d4cad89

  • Problem Code:

    if (installInfo.name) {

@jonathansampson jonathansampson added this to the 0.14.2 milestone Apr 14, 2017
@jonathansampson jonathansampson self-assigned this Apr 14, 2017
@alexwykoff alexwykoff changed the title All Predefined Messages Should Be Replaced Fixed messages shown on extensions page Apr 25, 2017
@luixxiul luixxiul changed the title Fixed messages shown on extensions page Fixed messages shown on extensions page - All Predefined Messages Should Be Replaced Apr 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.