Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

trying to sign in on ebay crashes the browser #8334

Closed
scarejar opened this issue Apr 15, 2017 · 21 comments
Closed

trying to sign in on ebay crashes the browser #8334

scarejar opened this issue Apr 15, 2017 · 21 comments
Labels
crash needs-info Another team member needs information from the PR/issue opener. priority/P3 Major loss of function. stale

Comments

@scarejar
Copy link

scarejar commented Apr 15, 2017 •
edited
Loading

  • Did you search for similar issues before submitting this one?
    Yes
  • Describe the issue you encountered:
    Trying to sign into ebay.com crashes the entire browser
  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 7 x64
  • Brave Version (revision SHA):
    rev 3de60d5
    -Can this error be reproduced?
    Yep
@luixxiul luixxiul added the crash label Apr 15, 2017
@bsclifton
Copy link
Member

@scarejar do you have Sync enabled? We had seen a similar issue to this, except with twitter.com

@bsclifton
Copy link
Member

Other issue for reference: #8004

@bsclifton bsclifton added the needs-info Another team member needs information from the PR/issue opener. label Apr 16, 2017
@scarejar
Copy link
Author

@bsclifton Nope, sync is off. Still reproducible, just visiting the sign in URL crashes the browser in about 2 seconds. Are there any logs or anything I can send over?

@cndouglas
Copy link

@scarejar Do you use any password managers (1Password, LastPass, etc.) or Pocket?

@scarejar
Copy link
Author

scarejar commented Apr 17, 2017 •
edited
Loading

@liunkae I use keepassx which provides no extensions/addons.
It could be internetdownloadmanager? Though as far as I know, it didn't try to install an extension. Also have discord open, unsure if that interferes with brave.

edit: disabled everything on start up so it's not sandboxie, internetdownload manger, everything search, and or discord. Ran the test on a VM and Brave doesn't crash interestingly so it really is just me though unsure as to why

edit2: reproduced in VM, fresh install of windows, so far it seems to be a Brave setting that is causing the crash. How do I reset all settings to default?

@cndouglas
Copy link

@scarejar To generate a fresh profile (on Windows):

  1. Quit Brave.
  2. Look for a folder at the following location: C:\Users\<username>\AppData\Roaming\brave.
  3. Rename the folder to something else (e.g. brave2).
  4. Open Brave again. It will automatically recreate the profile folder.

@scarejar
Copy link
Author

scarejar commented Apr 17, 2017 •
edited
Loading

@liunkae , @bsclifton Found how to reproduce crash. Disabled the built in HTML5 PDF reader and visiting the ebay sign in page/link: https://signin.ebay.com/ws/eBayISAPI.dll?SignIn&ru=http%3A%2F%2Fwww.ebay.com%2F

will result in a crash, does this happen to you mates?

@cndouglas
Copy link

Excellent job narrowing it down, @scarejar! I also can reproduce the crash. Some of my findings:

  • It reproduces every time.
  • It also crashes on macOS 10.12.x and Linux Ubuntu 16.04.x.
  • It happens with Brave 0.14.1, 0.14.2 RC2, and the current master (27a9e79).
  • It only happens when the built-in HTML5 PDF reader (pdfJS) is turned off.
  • It crashes the entire app, not just the browser process.

Steps to reproduce:

  1. Open Brave. Turn off the HTML5 PDF reader and restart the browser, if necessary.
  2. Open a new tab and click this link: https://signin.ebay.com/ws/eBayISAPI.dll?SignIn&ru=http%3A%2F%2Fwww.ebay.com%2F

@cndouglas cndouglas added verified and removed needs-info Another team member needs information from the PR/issue opener. labels Apr 18, 2017
@cndouglas cndouglas added this to the 0.15.1 milestone Apr 18, 2017
@cndouglas
Copy link

Top 50 site crash. Workaround: enable the HTML5 PDF reader.

@bbondy bbondy modified the milestones: 0.15.0, 0.15.1 Apr 25, 2017
@bbondy
Copy link
Member

bbondy commented Apr 25, 2017 •
edited
Loading

@liunkae could you test this with 0.15.0RC5, I'm not able to reproduce. I haven't tried before though. It might have been fixed with C58 upgrade or some other fix.

@bsclifton bsclifton self-assigned this Apr 25, 2017
@bsclifton
Copy link
Member

I'm able to reproduce the crash- it seems to crash the renderer (the entire app doesn't crash), showing the black tab with the dead tab guy
screen shot 2017-04-25 at 1 11 42 pm

@srirambv
Copy link
Collaborator

Ebay signin webview crash has been updated here #8474 based on report from user in community.
This can be closed in favour of #8474?

@bbondy
Copy link
Member

bbondy commented Apr 25, 2017

Sorry I was using mac.

@alexwykoff
Copy link
Contributor

Confirmed still an issue on 0.15.0 RC5 for Windows but not OS X

@bsclifton
Copy link
Member

Appears to be a dupe of #8474

@cndouglas
Copy link

No longer reproducible on macOS with 0.15.0 RC5. It was crashing the entire app before (in 0.14.1) on all platforms. #8474 and the behavior in 0.15.0 RC5 is probably separate (since it's Windows only and only crashes the renderer) but related (since it's the same URL).

@darkdh
Copy link
Member

darkdh commented Apr 26, 2017

fixed in brave/muon@ee77b72
please wait for muon v2.58.7

@darkdh darkdh closed this as completed Apr 26, 2017
@scarejar
Copy link
Author

Still reproducible for me. Currently on latest dev release:

Brave: 0.15.310
rev: 6b5e4e2
Muon: 3.0.201
libchromiumcontent: 58.0.3029.110
V8: 5.8.283.38
Node.js: 7.9.0
Update Channel: dev
os.platform: win32
os.release: 6.3.9600
os.arch: x64

@cndouglas
Copy link

cndouglas commented May 26, 2017 •
edited
Loading

Verified not fixed in Brave 0.15.310 on macOS 10.12.x. Reopening.

@cndouglas cndouglas reopened this May 26, 2017
@cndouglas cndouglas removed this from the 0.15.0 milestone May 26, 2017
@lukemulks
Copy link
Collaborator

+1 reported from Twitter
https://twitter.com/erenemre/status/878016246960095233

  • I'm on Sierra 10.12.5 (16F73).
  • Brave is 0.16.9 (rev fba98fc)

bug report: every time I go to https://t.co/DdS5xmmAN4, Brave crashes

@bsclifton bsclifton added the priority/P3 Major loss of function. label Sep 29, 2017
@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Nov 22, 2017
@cndouglas cndouglas mentioned this issue Nov 29, 2017
Open
@cndouglas
Copy link

Maybe related: #12124

@bsclifton bsclifton added needs-info Another team member needs information from the PR/issue opener. stale labels Aug 25, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
crash needs-info Another team member needs information from the PR/issue opener. priority/P3 Major loss of function. stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@bbondy @alexwykoff @luixxiul @bsclifton @lukemulks @darkdh @srirambv @cndouglas @scarejar