Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

set blank bookmark titles to [space] on import #8385

Closed
bradleyrichter opened this issue Apr 18, 2017 · 7 comments
Closed

set blank bookmark titles to [space] on import #8385

bradleyrichter opened this issue Apr 18, 2017 · 7 comments
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/bookmarks feature/importer wontfix

Comments

@bradleyrichter
Copy link
Contributor

When users have specifically edited chrome bookmarks to have NO title so they are displaying only FAVICONs, they would like the same appearance after importing into Brave.

Mission: retain blank name for a nameless bookmark during import process.

@jonathansampson
Copy link
Collaborator

Related to this is the inability for users to remove their bookmark title. Instead, they must edit and replace the title to a space. Deleting the title entirely results in no change to the bookmark itself.

Source: https://twitter.com/somenteangus/status/855114312536424448

@bradleyrichter
Copy link
Contributor Author

bradleyrichter commented Apr 22, 2017 via email

@bsclifton
Copy link
Member

@darkdh how easy/difficult do you think this change would this be? (You're have a lot more experience w/ the import code than me 😄 ). This may involve an electron change from what I understand (since the importer lives there, right? We re-use the Chromium importer)

@darkdh
Copy link
Member

darkdh commented Jun 6, 2017

We can use easy workaround before custom title being obsoleted.
In importer.on('add-bookmarks'... of app/importer.js,
we can set customTitle of site to space if we detect that bookmarks[i].title is empty

@jonathansampson
Copy link
Collaborator

@darkdh We should use a zero-width space, to avoid adding gaps between icons.

@bsclifton
Copy link
Member

Fixing this issue (and allowing for a blank title) may properly fix the issue:
#6585

@alexwykoff alexwykoff modified the milestones: 1.0.0, Backlog Nov 1, 2017
@eljuno
Copy link
Contributor

eljuno commented Jun 24, 2018

@bsclifton bsclifton added the addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. label Sep 7, 2018
@bsclifton bsclifton removed their assignment Sep 7, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/bookmarks feature/importer wontfix
Projects
None yet
Development

No branches or pull requests

6 participants