Import data gets duplicated after sync

[srirambv]

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Import data gets duplicated after sync

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version (revision SHA):
  0.15.0 RC5
  6638b91

• Steps to reproduce:
  1. Enable sync on pyramid 0
  2. Sync pyramid 1 with pyramid 0 using secret code
  3. Import browser data from Firefox and uncheck merge data into toolbar on pyramid 1
  4. Wait for the sycn to happen and data is sync'd on pyramid 0
  5. Pyramid 1 has two sets of imported data

  Edit: Updated the steps

  1. Import chrome data on machine
  2. Enable sync on machine
  3. Import Firefox data, do not merge data
  4. Wait for 3-4 mins firfox folder gets duplicated

• Actual result:
  Pyramid 1 gets duplicate data after sync

• Expected result:
  Data should not be duplicated upon Sync

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  No. Not checked. Could be a regression issue

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  Shared on slack

• Any related issues:
  cc: @diracdeltas @ayumi

[srirambv]

Actually this just needs to enable sync on the machine. Gif is a bit long need to watch completely.

[bsclifton]

Updated to impact/medium. I don't believe this was introduced by 0.15.0 and it only affects folks who use sync and import together (which is a much smaller subset than something affecting all users)

Let's push this to 0.15.1

[diracdeltas]

someone should check whether this was addressed by #9187

[alexwykoff]

@srirambv if you could ^

[diracdeltas]

it may also be fixed by #9406

[alexwykoff]

Confirmed fixed. Moving up to 0.17.x