Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Merge span.findButton with .closeButton on findbar.less #9234

Closed
luixxiul opened this issue Jun 3, 2017 · 0 comments · Fixed by #9235
Closed

Merge span.findButton with .closeButton on findbar.less #9234

luixxiul opened this issue Jun 3, 2017 · 0 comments · Fixed by #9235
Assignees
@luixxiul
Labels
feature/findbar misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.18.x Release

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 3, 2017 •
edited by cezaraugusto
Loading

Test plan:

#9235 (comment)

Describe the issue you encountered: Merge span.findButton with .closeButton on findbar.less.

Since there is only one span with the className findButton (and the element has its own classname, which is closeButton), it does not make much sense to have span.findButton.
@luixxiul luixxiul added this to the 0.18.x milestone Jun 3, 2017
@luixxiul luixxiul self-assigned this Jun 3, 2017
@luixxiul luixxiul mentioned this issue Jun 3, 2017
Merged
8 tasks
luixxiul referenced this issue Jun 3, 2017
@bradleyrichter
these edits ad 2 px to our tab height
615a6ec 
- this adds some needed space above and below the text string
- increases tab text to 12 on mac (already 12 on windows)
- tabs buttons adjusted to align properly

auditors: @bbondy @bsclifton
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/findbar misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging a pull request may close this issue.

Merge span.findButton with .closeButton on findbar.less
3 participants
@luixxiul @srirambv @LaurenWags