Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make session restore remember frame bfcache / history #963

Closed
bbondy opened this issue Mar 1, 2016 · 6 comments
Closed

Make session restore remember frame bfcache / history #963

bbondy opened this issue Mar 1, 2016 · 6 comments
Labels
feature/history fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core.

Comments

@bbondy
Copy link
Member

bbondy commented Mar 1, 2016

No description provided.

@luixxiul luixxiul mentioned this issue May 15, 2016
Closed
@bridiver
Copy link
Collaborator

NavigationController has several methods to facilitate this. GetEntryAtIndex, GetCurrentEntryIndex and Restore. We can add methods to the electron webcontents api to dump and restore the NavigationEntrys. I would recommend writing a v8 converter for NavigationEntryImpl that converts it to a DictionaryValue similar to HttpResponseHeaders and we can serialize the resulting javascript objects in the session store.

@bbondy bbondy added this to the 1.0.0 milestone Aug 2, 2016
@bbondy
Copy link
Member Author

bbondy commented Aug 2, 2016

cc @bsclifton

@bsclifton
Copy link
Member

bsclifton commented Aug 11, 2016 •
edited
Loading

This would be a great one 😄 I'd love to check this out. Wouldn't be too hard and we'd get the full history on our back/forward nav buttons

@bsclifton bsclifton self-assigned this Aug 11, 2016
@cortig cortig mentioned this issue Feb 1, 2016
Closed
@bridiver
Copy link
Collaborator

we should bring in the chrome TabRestoreService for this from component/sessions

@bsclifton
Copy link
Member

I'm assigned to this, but anyone who was wanting to get their feet wet w/ our electron fork (or if you had free cycles @bridiver) please feel free to grab this 😄

@bbondy bbondy modified the milestones: 1.1.0, 1.0.0 Oct 22, 2016
@bsclifton bsclifton mentioned this issue Nov 1, 2016
Closed
@LeonidVasilyev LeonidVasilyev mentioned this issue Jan 25, 2017
Closed
@echosa echosa mentioned this issue May 28, 2017
Closed
@Tomcatt Tomcatt mentioned this issue May 28, 2017
Closed
@alexwykoff alexwykoff modified the milestones: 1.1.0, Backlog Nov 1, 2017
@bsclifton bsclifton added the fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. label Aug 13, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 13, 2018
@bsclifton bsclifton removed their assignment Aug 13, 2018
@bsclifton
Copy link
Member

This is resolved with brave-core

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/history fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bridiver @bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton