From e4ff6786c96fba050e68229659c3fedea83e48a0 Mon Sep 17 00:00:00 2001 From: Anthony Tseng Date: Mon, 31 Oct 2016 18:13:10 -0400 Subject: [PATCH] Return menuId and throws error for non support properties Auditors: @bridiver, @bbondy --- atom/common/api/resources/context_menus_bindings.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/atom/common/api/resources/context_menus_bindings.js b/atom/common/api/resources/context_menus_bindings.js index 7aae0573b..db5b41429 100644 --- a/atom/common/api/resources/context_menus_bindings.js +++ b/atom/common/api/resources/context_menus_bindings.js @@ -34,6 +34,18 @@ var binding = { create: function (properties, cb) { var responseId = createResponseId() var menuItemId = properties.id || createMenuItemId() + if (properties.checked !== undefined) { + throw new Error('createProperties.checked of contextMenus.create is not supported yet') + } + if (properties.documentUrlPatterns !== undefined) { + throw new Error('createProperties.documentUrlPatterns of contextMenus.create is not supported yet') + } + if (properties.targetUrlPatterns !== undefined) { + throw new Error('createProperties.targetUrlPatterns of contextMenus.create is not supported yet') + } + if (properties.enabled !== undefined) { + throw new Error('createProperties.enabled of contextMenus.create is not supported yet') + } cb && ipc.once('chrome-context-menus-create-response-' + responseId, function(evt) { cb() }) @@ -43,6 +55,7 @@ var binding = { } }) ipc.send('chrome-context-menus-create', responseId, extensionId, menuItemId, properties) + return menuItemId } }