Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Social-media blocking settings tests #523

Open
MadhaviSeelam opened this issue May 25, 2023 · 1 comment
Open

Update Social-media blocking settings tests #523

MadhaviSeelam opened this issue May 25, 2023 · 1 comment
Labels
blocked work on this item is blocked or on hold OS/Desktop

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented May 25, 2023

Update testcases for the testcase "visit brave://settings/privacy -> Site and Shields Settings -> Cookies and site data... . " as new feature/functionality implemented brave://flags/#brave-google-sign-in-permission/Griffin study enabled. (Ref.brave/brave-browser#30364)

Case 1: Sites that rely on 3p cookies for Google Login
Allow

  • visited https://www.expensify.com/
  • clicked Google button
  • confirmed permission prompt shown for the site expensify.com
  • click Allow and keep the default permission until I close this site
  • confirmed permission prompt is dismissed
  • go to brave://settings/content/googleSignIn page
  • confirmed https://www.expensify.com:443 site URL is shown in Allowed to use third-party cookies for legacy Google Sign-In entry
  • open brave://settings/cookies in a new tab
  • confirmed entries are shown Sites that can always use cookies are shown (for https://accounts.google.com, it reads as embedded on [.]expensify.com`. Same for https://[.]firebaseapp.com)
  • sign out and close the tab
  • the entry https://www.expensify.com:443 is removed from Allowed to use third-party cookies for legacy Google Sign-In

Block

Case 2: Sites that don't rely on 3p cookies for Google Login
No permission prompt shown for sites that don't rely on 3p cookies - nytimes.com

Case 3: Disable default permissions Sites can ask to use legacy Google Sign-In via third-party cookies in brave://settings/content/googleSignIn

  • new profile
  • launch Brave
  • opened a new-tab
  • visit brave://flags
  • set Enable Google Sign-In Permission Prompt to enabled in brave://flags and click Relaunch
  • visited brave://settings/content/googleSignIn
  • disabled Sites can ask to use legacy Google Sign-In via third-party cookies
  • visited https://www.expensify.com/
  • clicked Google button
  • confirmed error message There was an error signing you in with Google
@LaurenWags LaurenWags added the blocked work on this item is blocked or on hold label Nov 28, 2023
@LaurenWags
Copy link
Member

Added a "blocked" label to this one as we're currently sitting at 25% enabled on Release channel with this one. Not sure of the plan to increase the rollout on Release channel atm - we should discuss and determine if we want to make these changes now or wait for further rollout on Release channel.

Can refer to https://griffin.brave.com/ and look for "BraveGoogleSignInPermissionStudy" to see rollout percentages for Release. Currently Beta/Nightly rollout of this feature is 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked work on this item is blocked or on hold OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants