From 15ed90250508879b67bce5a1a55acda27d30193c Mon Sep 17 00:00:00 2001 From: Kamil Jozwiak Date: Tue, 1 Mar 2022 22:08:45 -0500 Subject: [PATCH] Adding PWA checks to desktop passes --- wikitemplate-ReducedDesktop.md | 12 ++++++++++++ wikitemplate-minorCRbumpDesktop.md | 14 +++++++++++++- wikitemplate.md | 12 ++++++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) diff --git a/wikitemplate-ReducedDesktop.md b/wikitemplate-ReducedDesktop.md index e67b85b..1919fc5 100644 --- a/wikitemplate-ReducedDesktop.md +++ b/wikitemplate-ReducedDesktop.md @@ -35,6 +35,17 @@ - [ ] Verify that opening a NTP doesn't trigger any outbound connections related to widgets without user interaction - [ ] Delete Adblock folder from browser profile and restart browser. Visit `brave://components` and verify `Brave Ad Block Updater` downloads and update the component. Repeat for all Brave components +#### PWA (Progressive Web Application) + +- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` with `Open as window` selected creates a shortcut and launches a new window without any issues + - [ ] ensure that a separate PWA window is being opened (this window will not have the URL bar visible) + - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut + - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed + - [ ] ensure that you can uninstall the PWA via `Hamburger Menu` -> `Uninstall PWA` +- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` without `Open as window` selected creates a shortcut and creates a new tab + - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut + - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed + ### Upgrade - [ ] Make sure that data from the last version appears in the new version OK @@ -47,6 +58,7 @@ - [ ] Stored passwords are preserved - [ ] Sync chain created in previous version is retained - [ ] Social media blocking buttons changes are retained + - [ ] Previously created PWA shortcuts can still be used/launch without any issues - [ ] Rewards - [ ] Wallet balance is retained - [ ] Auto-contribute list is retained diff --git a/wikitemplate-minorCRbumpDesktop.md b/wikitemplate-minorCRbumpDesktop.md index 298b4a1..70f1009 100644 --- a/wikitemplate-minorCRbumpDesktop.md +++ b/wikitemplate-minorCRbumpDesktop.md @@ -11,7 +11,18 @@ - [ ] Verify that you are able to successfully join Rewards on a fresh profile -## Update tests +#### PWA (Progressive Web Application) + +- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` with `Open as window` selected creates a shortcut and launches a new window without any issues + - [ ] ensure that a separate PWA window is being opened (this window will not have the URL bar visible) + - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut + - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed + - [ ] ensure that you can uninstall the PWA via `Hamburger Menu` -> `Uninstall PWA` +- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` without `Open as window` selected creates a shortcut and creates a new tab + - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut + - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed + +### Update tests - [ ] Verify visiting `brave://settings/help` triggers update check - [ ] Verify once update is downloaded, prompts to `Relaunch` to install update @@ -28,6 +39,7 @@ - [ ] Stored passwords are preserved - [ ] Sync chain created in previous version is retained - [ ] Social media blocking buttons changes are retained + - [ ] Previously created PWA shortcuts can still be used/launch without any issues - [ ] Rewards - [ ] Wallet balance is retained - [ ] Auto-contribute list is retained diff --git a/wikitemplate.md b/wikitemplate.md index f4a9962..86523db 100644 --- a/wikitemplate.md +++ b/wikitemplate.md @@ -47,6 +47,17 @@ - [ ] Verify `Widevine Notification` is shown when you visit HBO Max for the first time - [ ] Test that you can stream on HBO Max on a fresh profile after installing Widevine +#### PWA (Progressive Web Application) + +- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` with `Open as window` selected creates a shortcut and launches a new window without any issues + - [ ] ensure that a separate PWA window is being opened (this window will not have the URL bar visible) + - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut + - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed + - [ ] ensure that you can uninstall the PWA via `Hamburger Menu` -> `Uninstall PWA` +- [ ] Verify that creating a PWA via `Hamburger Menu` -> `More tools` -> `Create shortcut...` without `Open as window` selected creates a shortcut and creates a new tab + - [ ] ensure that you can launch the PWA from different locations by moving around the created shortcut + - [ ] ensure that you can launch the PWA via the created shortcut when Brave is closed + ### Geolocation - [ ] Check that https://browserleaks.com/geo works and shows correct location @@ -224,6 +235,7 @@ - [ ] Stored passwords are preserved - [ ] Sync chain created in previous version is retained - [ ] Social media-blocking buttons changes are retained + - [ ] Previously created PWA shortcuts can still be used/launch without any issues - [ ] Rewards - [ ] Wallet balance is retained - [ ] Auto-contribute list is retained