This repository has been archived by the owner on Mar 8, 2024. It is now read-only.
Task/#8 #9
Merged
Task/#8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is mean all firebase functionality is now exposed, but the library user doesn't have a dependency on firebase ml lib. This will also mean that all classes are mockable because they have internal classes or primitives as params.
NickHolcombe
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created wrapper classes for all the relevant Firebase classes. This mean all firebase functionality is now exposed, but the library user doesn't have a dependency on firebase ml lib. This will also mean that all classes are mockable because they have internal classes or primitives as params.
This fixes #8
This change is