Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Media.is_video by check on Media.datatype #262

Closed
bruvellu opened this issue Nov 26, 2023 · 0 comments · Fixed by #269
Closed

Replace Media.is_video by check on Media.datatype #262

bruvellu opened this issue Nov 26, 2023 · 0 comments · Fixed by #269
Labels
bug Issues with bugs that need to be fixed

Comments

@bruvellu
Copy link
Owner

The is_video method is re-checking something that has already been established: the datatype. The field should be used whenever we need to check the type of file. In the templates, the code needs to be adapted from {% if media.is_video %} to {% if media.datatype == 'video' %}.
@bruvellu bruvellu added the bug Issues with bugs that need to be fixed label Nov 26, 2023
@Felyppe1 Felyppe1 mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues with bugs that need to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/medias from my curations page bruvellu/cifonauta
1 participant
@bruvellu