[Bug] 3.24.2 - up to - 3.25.3: href empty from links in rendering tests

[esbanarango]

🐞 Describe the Bug

In a rendering test the link helper always return an emptyhref.

🔬 Minimal Reproduction

  test('href test', async function (assert) {
    assert.expect(1);
    await render(hbs`
      {{#let (link route="login") as |l|}}
        <a href={{l.url}}>Login</a>
      {{/let}}
    `);
    assert.dom('a').hasAttribute('href', `/login`);
  });

😕 Actual Behavior

Element a has an empty attribute "href".

🤔 Expected Behavior

Element a has attribute "href" with value "/login"

🌍 Environment

• Ember: 3.25.3

➕ Additional Context

emberjs/ember.js#19408

[rwjblue]

Depending on how this addon does URL generation, I suspect it has to do roughly the same thing as the Ember PR's:

• Lazily setup the router in non-application tests emberjs/ember.js#19080
• Lazily setup the router in non-application tests for <LinkTo> component emberjs/ember.js#19326
• [BUGFIX lts] LinkTo with incomplete model failing in rendering tests emberjs/ember.js#19387
• [LTS fix] only return empty href when LinkTo href generation throws error emberjs/ember.js#19395

[Turbo87]

@esbanarango that is roughly how Ember up until now also behaved and the addon tries to follow what Ember itself does. we even explicitly test for this behavior in the test suite here.

[esbanarango]

@Turbo87 mmmm that's weird. Looks like this is actually testing it to be "empty" ☹️.

https://github.com/buschtoens/ember-link/blob/master/tests/integration/components/link-test.ts#L40 or to be an ember selector (?) if you're using the setupLink hook:

(Using setupLink hook).

I don't think this is up with how Ember is behaving now.

This same test:

module('Integration | Component | TMP', function (hooks) {
  setupRenderingTest(hooks);

  test('href test', async function (assert) {
    assert.expect(1);
    await render(hbs`<LinkTo @route="login">test</LinkTo>`);
    assert.dom('a').hasAttribute('href', `/login`);
  });
});

works fine with ember-source: 3.25.3.

But this one breaks with ember-link: 1.3.1:

module('Integration | Component | TMP', function (hooks) {
  setupRenderingTest(hooks);

  test('href test', async function (assert) {
    assert.expect(1);
    await render(hbs`
      {{#let (link route="login") as |l|}}
        <a href={{l.url}}>Login</a>
      {{/let}}
    `);
    assert.dom('a').hasAttribute('href', `/login`);
  });
});

GitHub

buschtoens/ember-link

Link primitive to pass around self-contained route references. It's {{link-to}}, but better! - buschtoens/ember-link

[Turbo87]

I don't think this is up with how Ember is behaving now.

yes, because Ember changed its behavior multiple times lately 🤷‍♂️

[rwjblue]

Yeah :/ sorry about this. We are trying to make the default behavior appropriate out of the box. From my perspective, the current implemetnation (in 3.24.3 and 3.25.3) is much better...

[rogeraraujo90]

I asked if this behavior were a bug in the related issue. Good to know that we will have a fix for it! 👏🏼🧡

[esbanarango]

@Turbo87 I tried tackling this issue but I think I'm missing some context on how you guys are matching the way Ember behaves. Is this on your radar 🙏 ?