Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfound exports LinkParams and UILinkParams under Embroider #717

Closed
bertdeblock opened this issue Aug 16, 2022 · 1 comment · Fixed by #718
Closed

Unfound exports LinkParams and UILinkParams under Embroider #717

bertdeblock opened this issue Aug 16, 2022 · 1 comment · Fixed by #718

Comments

@bertdeblock
Copy link
Contributor

I assume this is because these exports are actually TS interfaces and should be exported using export type?

WARNING in ./node_modules/ember-link/index.js 1:0-75
export 'LinkParams' (reexported as 'LinkParams') was not found in './link' (possible exports: UILink, default, isQueryParams)
 @ ./components/dropdown/actions/link/index.js 13:0-34 16:117-121
 @ ./tests/integration/components/dropdown/actions/link-test.js 5:0-74 7:9-11
 @ ./assets/test.js 32:13-85

WARNING in ./node_modules/ember-link/index.js 1:0-75
export 'UILinkParams' (reexported as 'UILinkParams') was not found in './link' (possible exports: UILink, default, isQueryParams)
 @ ./components/dropdown/actions/link/index.js 13:0-34 16:117-121
 @ ./tests/integration/components/dropdown/actions/link-test.js 5:0-74 7:9-11
 @ ./assets/test.js 32:13-85
@bertdeblock bertdeblock changed the title Unfound exports under Embroider Unfound exports LinkParams and UILinkParams under Embroider Aug 16, 2022
@buschtoens
Copy link
Owner

Good catch! Yes, I think that's the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants