Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getLinkParamsFromRouteInfo does not collect models for the entire RouteInfo tree #797

Open
bertdeblock opened this issue Mar 29, 2024 · 0 comments
Open

getLinkParamsFromRouteInfo does not collect models for the entire RouteInfo tree #797

bertdeblock opened this issue Mar 29, 2024 · 0 comments

Comments

@bertdeblock
Copy link
Contributor

At the moment, only paramNames on the leaf RouteInfo instance is used here:
https://github.com/buschtoens/ember-link/blob/main/ember-link/src/services/link-manager.ts#L100

But I think we need to traverse up the entire tree (using the parent property) to collect all models?

Otherwise, Ember's router throws an error when creating links using the fromURL option, and providing a URL with e.g. multiple dynamic segments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bertdeblock