Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanelResizeHandle doesn't trigger cursor change on hover after changing disabled state #377

Open
Sam-Apostel opened this issue Jul 25, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@Sam-Apostel
Copy link

Right after changing the disabled prop of a PanelResizeHandle from true to false, the data-resize-handle-state doesn't update on hover.

Reproduce

  1. render <PanelResizeHandle disabled={true} />
  2. change disabled to false
  3. hover over the PanelResizeHandle.

Expected

the cursor changes to a resize and the data-resize-handle-state attribute changes from inactive to hover

Actual

The cursor doesn't change and the data-resize-handle-state attribute is still inactive

NOTE: Clicking anywhere on the page fixes this. Resizing itself is not broken, just the hover state.

I am willing to look into this and PR if welcome

@bvaughn
Copy link
Owner

bvaughn commented Jul 25, 2024

Hey @Sam-Apostel! Pull requests for things like this are always welcome. As are some kind of runnable repro case (Code Sandbox, or a GitHub project that I can checkout and run)

@bvaughn bvaughn added the help wanted Extra attention is needed label Jul 25, 2024
@CHE1RON
Copy link
Contributor

CHE1RON commented Oct 1, 2024

Running in this also, when first loading your example page, you may reproduce like this:

  1. visit page first time
  2. go back to "Home"
  3. select another example page (eg "nested groups")
  4. hover over resize handles
  5. no "resizable" action being indicated by cursor (= style not injected in head)
  6. click somewhere on the page, hover resize handle = working as expected

Since this is my first time working with your great library, I'll see if I can look into this later! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants