Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Moving ApprovedHosts to IList instead of IEnumerable #17

Closed
calebjenkins opened this issue May 2, 2022 · 2 comments
Closed

RFC: Moving ApprovedHosts to IList instead of IEnumerable #17

calebjenkins opened this issue May 2, 2022 · 2 comments

Comments

@calebjenkins
Copy link
Owner

Request for comment @floyd-may

I'm looking at changing ApprovedHosts in FakeAuthOptions to IList instead of IEnumerable.

This is for parity with the Claims collection. (Also IList) to make the set up in StartUp easier (provides .Add()) Everything else stays the same and all tests seem to pass.

Branch: https://github.com/calebjenkins/FakeAuth/tree/dev/feature-13-evaluating-2.0

@floyd-may
Copy link
Collaborator

LGTM! Do it.

@calebjenkins
Copy link
Owner Author

completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants