Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple active keychain selection does not work #439

Closed
cppforlife opened this issue Sep 29, 2022 · 0 comments · Fixed by #440
Closed

multiple active keychain selection does not work #439

cppforlife opened this issue Sep 29, 2022 · 0 comments · Fixed by #440
Assignees
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed

Comments

@cppforlife
Copy link
Contributor

cppforlife commented Sep 29, 2022

Describe the problem/challenge you have

$ IMGPKG_ACTIVE_KEYCHAINS=gke,ecr imgpkg pull -i anything -o /tmp/lol
imgpkg: Error: Creating registry keychain:
  Unable to load keychain for , available keychains [aks, ecr, gke, github]

it seems that we are picking up empty string instead of env value when comma is present: https://github.com/vmware-tanzu/carvel-imgpkg/blob/d5c9d0c9a8c62293f371fcd7b8d772dab215f795/pkg/imgpkg/cmd/registry_flags.go#L85. this means i believe that we can only support one active keychain at a time.

Describe the solution you'd like

abillity to support multiple active keychains

Anything else you would like to add:
[Additional information that will assist in solving the issue.]


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help work on this issue.

@cppforlife cppforlife added enhancement This issue is a feature request carvel triage This issue has not yet been reviewed for validity labels Sep 29, 2022
@joaopapereira joaopapereira added bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed and removed enhancement This issue is a feature request carvel triage This issue has not yet been reviewed for validity labels Sep 29, 2022
@joaopapereira joaopapereira self-assigned this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants